Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] enable tests #9865

Merged
merged 10 commits into from
May 2, 2024
Merged

Conversation

joshua-stauffer
Copy link
Member

@joshua-stauffer joshua-stauffer commented May 1, 2024

The majority of tests in test_spark_filesystem_datasource.py were being programmatically skipped. This PR re-enables them, and temporarily xfails tests related to partitioners, which will be fixed in a follow up PR.

Copy link

netlify bot commented May 1, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 16aa429
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6633fd490a13d40008835664

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.63%. Comparing base (bf6d453) to head (16aa429).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9865      +/-   ##
===========================================
+ Coverage    78.61%   78.63%   +0.02%     
===========================================
  Files          484      484              
  Lines        42533    42536       +3     
===========================================
+ Hits         33436    33449      +13     
+ Misses        9097     9087      -10     
Flag Coverage Δ
3.10 64.51% <ø> (+0.01%) ⬆️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 64.51% <ø> (+0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.90% <ø> (-0.01%) ⬇️
3.11 aws_deps 44.86% <ø> (-0.01%) ⬇️
3.11 big 55.98% <ø> (-0.01%) ⬇️
3.11 databricks 46.01% <ø> (-0.01%) ⬇️
3.11 filesystem 61.20% <ø> (-0.01%) ⬇️
3.11 mssql 48.88% <ø> (-0.01%) ⬇️
3.11 mysql 48.93% <ø> (-0.01%) ⬇️
3.11 postgresql 52.79% <ø> (-0.01%) ⬇️
3.11 snowflake 46.64% <ø> (-0.01%) ⬇️
3.11 spark 57.06% <ø> (+0.13%) ⬆️
3.11 trino 50.79% <ø> (-0.01%) ⬇️
3.8 64.54% <ø> (+0.01%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.90% <ø> (-0.01%) ⬇️
3.8 aws_deps 44.87% <ø> (-0.01%) ⬇️
3.8 big 55.99% <ø> (-0.01%) ⬇️
3.8 databricks 46.02% <ø> (-0.01%) ⬇️
3.8 filesystem 61.22% <ø> (-0.01%) ⬇️
3.8 mssql 48.86% <ø> (-0.01%) ⬇️
3.8 mysql 48.92% <ø> (-0.01%) ⬇️
3.8 postgresql 52.78% <ø> (-0.01%) ⬇️
3.8 snowflake 46.65% <ø> (-0.01%) ⬇️
3.8 spark 57.02% <ø> (+0.13%) ⬆️
3.8 trino 50.77% <ø> (-0.01%) ⬇️
3.9 64.53% <ø> (+0.01%) ⬆️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 49.00% <ø> (-0.01%) ⬇️
docs-creds-needed 50.09% <ø> (-0.01%) ⬇️
docs-spark 48.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@joshua-stauffer joshua-stauffer added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit bcbc402 May 2, 2024
69 checks passed
@joshua-stauffer joshua-stauffer deleted the m/v1-307/add_back_spark_tests2 branch May 2, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants