Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Ensure Spark can start #9866

Merged
merged 1 commit into from
May 1, 2024

Conversation

joshua-stauffer
Copy link
Member

Pyspark 3.4.0 raises a KeyError in the execution engine when calling pyspark.SparkConnectSession.builder.getOrCreate():


    def getOrCreate(self) -> "SparkSession":
>       return SparkSession(connectionString=self._options["spark.remote"])
E       KeyError: 'spark.remote'

whereas pyspark.SparkSession.builder.getOrCreate() is successful. This PR adds the KeyError to the except block in order to allow spark to start up.

Copy link

netlify bot commented May 1, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 31f1f97
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6632b17ec20e950008973239

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (1610eb9) to head (31f1f97).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9866   +/-   ##
========================================
  Coverage    81.21%   81.21%           
========================================
  Files          502      502           
  Lines        44687    44687           
========================================
  Hits         36293    36293           
  Misses        8394     8394           
Flag Coverage Δ
3.10 65.68% <100.00%> (ø)
3.11 65.68% <100.00%> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.48% <100.00%> (ø)
3.11 aws_deps 44.29% <100.00%> (ø)
3.11 big 59.50% <100.00%> (ø)
3.11 databricks 45.37% <100.00%> (ø)
3.11 filesystem 62.25% <100.00%> (ø)
3.11 mssql 48.11% <100.00%> (ø)
3.11 mysql 48.17% <100.00%> (ø)
3.11 postgresql 51.82% <100.00%> (ø)
3.11 snowflake 45.97% <100.00%> (ø)
3.11 spark 58.09% <100.00%> (ø)
3.11 trino 51.14% <100.00%> (ø)
3.8 65.69% <100.00%> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.49% <100.00%> (ø)
3.8 aws_deps 44.30% <100.00%> (ø)
3.8 big 59.50% <100.00%> (ø)
3.8 databricks 45.38% <100.00%> (ø)
3.8 filesystem 62.26% <100.00%> (ø)
3.8 mssql 48.10% <100.00%> (ø)
3.8 mysql 48.15% <100.00%> (ø)
3.8 postgresql 51.81% <100.00%> (ø)
3.8 snowflake 45.98% <100.00%> (ø)
3.8 spark 58.05% <100.00%> (ø)
3.8 trino 51.13% <100.00%> (ø)
3.9 65.69% <100.00%> (ø)
cloud 0.00% <0.00%> (ø)
docs-basic 52.19% <100.00%> (ø)
docs-creds-needed 53.29% <100.00%> (ø)
docs-spark 51.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-stauffer joshua-stauffer added this pull request to the merge queue May 1, 2024
Merged via the queue into develop with commit afadd61 May 1, 2024
69 checks passed
@joshua-stauffer joshua-stauffer deleted the m/v1-307/ensure_spark_can_start branch May 1, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants