-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Update context factories to delete by name #9870
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9870 +/- ##
========================================
Coverage 78.63% 78.63%
========================================
Files 484 484
Lines 42536 42537 +1
========================================
+ Hits 33449 33450 +1
Misses 9087 9087
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…_expectations into m/v1-232/context_factory_delete
…_expectations into m/v1-232/context_factory_delete
@@ -118,7 +118,7 @@ def delay_rerun(*args): | |||
backend_dependencies=[], | |||
), | |||
IntegrationTestFixture( | |||
name="delete_an_expectation_suite.py", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
Rather than accepting the rich type, we should just take an identifier to delete.
Requires a roundtrip for analytics but we've deemed to be a non-issue.
invoke lint
(usesruff format
+ruff check
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!