[FEATURE] Directory Asset BatchDefinition API #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
This reverts commit 362b4f0.
joshua-stauffer
force-pushed
the
f/v1-306/directory_asset
branch
from
d0a2e95
to
82890a3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9874 +/- ##
===========================================
- Coverage 78.25% 77.99% -0.26%
===========================================
Files 484 495 +11
Lines 42394 42537 +143
===========================================
+ Hits 33174 33176 +2
- Misses 9220 9361 +141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshua-stauffer
commented
May 3, 2024
Comment on lines
1
to
40
| from __future__ import annotations | ||
|
|
||
| from typing import Type | ||
|
|
||
| from great_expectations.datasource.fluent.data_asset.path.file_asset import FileDataAsset | ||
| from great_expectations.datasource.fluent.dynamic_pandas import _generate_pandas_data_asset_models | ||
|
|
||
| _PANDAS_FILE_TYPE_READER_METHOD_UNSUPPORTED_LIST = ( | ||
| # "read_csv", | ||
| # "read_json", | ||
| # "read_excel", | ||
| # "read_parquet", | ||
| "read_clipboard", # not path based | ||
| # "read_feather", | ||
| # "read_fwf", | ||
| "read_gbq", # not path based | ||
| # "read_hdf", | ||
| # "read_html", | ||
| # "read_orc", | ||
| # "read_pickle", | ||
| # "read_sas", # invalid json schema | ||
| # "read_spss", | ||
| "read_sql", # not path based & type-name conflict | ||
| "read_sql_query", # not path based | ||
| "read_sql_table", # not path based | ||
| "read_table", # type-name conflict | ||
| # "read_xml", | ||
| ) | ||
| _FILE_PATH_ASSET_MODELS = _generate_pandas_data_asset_models( | ||
| FileDataAsset, | ||
| blacklist=_PANDAS_FILE_TYPE_READER_METHOD_UNSUPPORTED_LIST, | ||
| use_docstring_from_method=True, | ||
| skip_first_param=True, | ||
| ) | ||
| CSVAsset: Type[FileDataAsset] = _FILE_PATH_ASSET_MODELS.get("csv", FileDataAsset) | ||
| ExcelAsset: Type[FileDataAsset] = _FILE_PATH_ASSET_MODELS.get("excel", FileDataAsset) | ||
| FWFAsset: Type[FileDataAsset] = _FILE_PATH_ASSET_MODELS.get("fwf", FileDataAsset) | ||
| JSONAsset: Type[FileDataAsset] = _FILE_PATH_ASSET_MODELS.get("json", FileDataAsset) | ||
| ORCAsset: Type[FileDataAsset] = _FILE_PATH_ASSET_MODELS.get("orc", FileDataAsset) | ||
| ParquetAsset: Type[FileDataAsset] = _FILE_PATH_ASSET_MODELS.get("parquet", FileDataAsset) |
There was a problem hiding this comment.
rename module to generated_assets.py
tyler-hoffman
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is prework to add a fluent-style batch definition API to directory data assets. In order to support this,
_FilePathDataAssetand direct descendents have been refactored in order to allow regex-based assets to use RegexPartitioners, and directory-based assets to use column partitioners.SparkPartitionershave been brought back asDataframePartitioners.other refactors
_FilePathDataAssethas been renamed toPathDataAssetgreat_expectations.datasource.fluent.data_asset.data_connectorpackage has been moved out ofdata_assetto thefluentpackage.spark_file_path_datasource.pyand into thedata_asset.sparkpackagepandas_file_path_datasource.pyand into thedata_asset.pandaspackage