Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove dataconnector tests that reference block style D… #9879

Merged

Conversation

tyler-hoffman
Copy link
Contributor

…atasources

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented May 3, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 4cd7017
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663525e41db8b0000926a54f

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.23%. Comparing base (9b525ca) to head (4cd7017).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9879      +/-   ##
===========================================
- Coverage    78.61%   78.23%   -0.39%     
===========================================
  Files          484      484              
  Lines        42394    42394              
===========================================
- Hits         33330    33165     -165     
- Misses        9064     9229     +165     
Flag Coverage Δ
3.10 64.40% <ø> (-0.07%) ⬇️
3.11 64.40% <ø> (-0.08%) ⬇️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.01% <ø> (ø)
3.11 aws_deps 44.94% <ø> (ø)
3.11 big 55.76% <ø> (-0.35%) ⬇️
3.11 databricks 46.10% <ø> (ø)
3.11 filesystem 61.27% <ø> (-0.05%) ⬇️
3.11 mssql 48.98% <ø> (ø)
3.11 mysql 49.04% <ø> (ø)
3.11 postgresql 52.90% <ø> (ø)
3.11 snowflake 46.73% <ø> (-0.01%) ⬇️
3.11 spark 57.19% <ø> (ø)
3.11 trino 50.90% <ø> (ø)
3.8 64.40% <ø> (-0.09%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.02% <ø> (ø)
3.8 aws_deps 44.96% <ø> (ø)
3.8 big 55.77% <ø> (-0.35%) ⬇️
3.8 databricks 46.11% <ø> (ø)
3.8 filesystem 61.29% <ø> (-0.05%) ⬇️
3.8 mssql 48.96% <ø> (ø)
3.8 mysql 49.02% <ø> (ø)
3.8 postgresql 52.89% <ø> (ø)
3.8 snowflake 46.74% <ø> (ø)
3.8 spark 57.15% <ø> (ø)
3.8 trino 50.88% <ø> (ø)
3.9 64.41% <ø> (-0.07%) ⬇️
cloud 0.00% <ø> (ø)
docs-basic 49.11% <ø> (ø)
docs-creds-needed 50.23% <ø> (ø)
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyler-hoffman tyler-hoffman added this pull request to the merge queue May 3, 2024
Merged via the queue into develop with commit bd52c5f May 3, 2024
68 checks passed
@tyler-hoffman tyler-hoffman deleted the m/v1-25/remove-data_connector_for_block_style branch May 3, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants