[MAINTENANCE] Remove remaining references to block style datasources #9881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
tyler-hoffman
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9881 +/- ##
===========================================
- Coverage 77.77% 77.36% -0.42%
===========================================
Files 494 493 -1
Lines 42389 42360 -29
===========================================
- Hits 32967 32770 -197
- Misses 9422 9590 +168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… fix a test to use ephemeral context)
…ock-style-datasoures
…ock-style-datasoures
This reverts commit fe6be93.
cdkini
reviewed
May 8, 2024
| include_pandas: bool = True, | ||
| include_spark: bool = True, | ||
| ) -> AbstractDataContext: | ||
| def build_in_memory_runtime_context() -> AbstractDataContext: |
There was a problem hiding this comment.
not relevant to your PR but I don't know why this method is in our repo if we only really use it as a test util - same comment for a lot of the methods in here we might want to write a ticket about removing them to undo some import cycles they cause
cdkini
reviewed
May 8, 2024
tests/data_context/abstract_data_context/test_list_datasources.py
Outdated
Show resolved
Hide resolved
cdkini
reviewed
May 8, 2024
| @@ -598,7 +597,10 @@ def test_escape_all_config_variables_skip_substitution_vars( | |||
|
|
|||
|
|
|||
| @pytest.mark.filesystem | |||
| def test_create_data_context_and_config_vars_in_code(tmp_path_factory, monkeypatch): | |||
| # @mock.patch.object(sa, "create_engine") | |||
cdkini
reviewed
May 8, 2024
tests/expectations/core/test_expect_queried_column_value_frequency_to_meet_threshold.py
Show resolved
Hide resolved
cdkini
approved these changes
May 8, 2024
billdirks
reviewed
May 8, 2024
| include_pandas: bool = True, | ||
| include_spark: bool = True, | ||
| ) -> AbstractDataContext: | ||
| def build_in_memory_runtime_context() -> AbstractDataContext: |
There was a problem hiding this comment.
Is this a test util in the normal code package?
Now it's building a context with no datasources, maybe we can delete this whole function? Maybe that involves deleting BaseDatasource which is happening as a followup?
| @@ -894,61 +893,6 @@ def titanic_pandas_data_context_with_v013_datasource_with_checkpoints_v1_with_em | |||
| context = get_context(context_root_dir=context_path) | |||
| assert context.root_directory == context_path | |||
|
|
|||
| datasource_config: str = f""" | |||
There was a problem hiding this comment.
Wondering if we can delete this whole fixture since there is no longer a datasource.
tyler-hoffman
deleted the
m/v1-25/remove-remaining-references-to-block-style-datasoures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all references to block style
Datasourceclass. Note: This does not removeBaseDatasource; that will be removed in a followup PR.NOTE: This raises some new
DataContextErrorsin places if we get a non-fluent datasource. These errors should not be hit and are just to make the type checker happy.There are a lot of other test deletions in here that I think are reasonable. The main categories:
Datasourcetestsinvoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!