Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Minor Updates to GX Cloud Expectations Topics #9884

Merged
merged 1 commit into from
May 6, 2024

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented May 6, 2024

Recently, the GX Cloud UI for creating and editing Expectations was modified. As a result, the documentation required minor modifications. This PR implements the necessary documentation changes.

Definition of done:

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented May 6, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 643306c
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6638ecd6bdcfa60008692f98
😎 Deploy Preview https://deploy-preview-9884.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.85%. Comparing base (d455f54) to head (643306c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9884      +/-   ##
===========================================
- Coverage    77.99%   75.85%   -2.15%     
===========================================
  Files          495      495              
  Lines        42539    42539              
===========================================
- Hits         33177    32266     -911     
- Misses        9362    10273     +911     
Flag Coverage Δ
3.10 64.21% <ø> (ø)
3.11 64.21% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.86% <ø> (ø)
3.11 aws_deps 44.78% <ø> (ø)
3.11 big 55.74% <ø> (ø)
3.11 databricks 45.96% <ø> (ø)
3.11 filesystem ?
3.11 mssql 48.77% <ø> (ø)
3.11 mysql 48.83% <ø> (ø)
3.11 postgresql 52.74% <ø> (ø)
3.11 snowflake 46.57% <ø> (ø)
3.11 spark 57.16% <ø> (ø)
3.11 trino 50.74% <ø> (ø)
3.8 64.23% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.86% <ø> (ø)
3.8 aws_deps 44.80% <ø> (ø)
3.8 big 55.75% <ø> (ø)
3.8 databricks 45.97% <ø> (ø)
3.8 filesystem ?
3.8 mssql 48.75% <ø> (ø)
3.8 mysql 48.81% <ø> (ø)
3.8 postgresql ?
3.8 snowflake ?
3.8 spark 57.13% <ø> (ø)
3.8 trino 50.72% <ø> (ø)
3.9 64.23% <ø> (ø)
cloud ?
docs-basic 49.10% <ø> (ø)
docs-creds-needed 50.22% <ø> (ø)
docs-spark 48.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwcanuck kwcanuck added this pull request to the merge queue May 6, 2024
Merged via the queue into develop with commit 12659d0 May 6, 2024
63 checks passed
@kwcanuck kwcanuck deleted the expectation-updates branch May 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants