[BUGFIX] Ensure that SlackNotificationAction renders properly
#9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_expectations into m/_/patch_slack_notification_action_rendering
✅ Deploy Preview for niobium-lead-7998 canceled.
|
✅ Deploy Preview for niobium-lead-7998 canceled.
|
cdkini
commented
May 6, 2024
Comment on lines
-320
to
-329
| def _send_notifications_in_batches(self, blocks, payload, result): | ||
| text = blocks[0]["text"]["text"] | ||
| chunks, chunk_size = len(text), len(text) // 4 | ||
| split_text = [ | ||
| text[position : position + chunk_size] for position in range(0, chunks, chunk_size) | ||
| ] | ||
| for batch in split_text: | ||
| payload["text"] = batch | ||
| result = self._get_slack_result(payload) | ||
| return result |
There was a problem hiding this comment.
Feels like an optimization we don't need - would be easy enough to add something like this if we need it later on
cdkini
commented
May 6, 2024
| @@ -142,17 +141,28 @@ def _build_report_element_block( | |||
|
|
|||
| return None | |||
|
|
|||
| def _build_divider_block(self) -> dict: | |||
| return {"type": "divider"} | |||
| def concatenate_text_blocks(self, text_blocks: list[dict], name: str, success: bool) -> dict: | |||
There was a problem hiding this comment.
Some minor refactoring of existing logic
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9885 +/- ##
===========================================
- Coverage 77.99% 77.28% -0.71%
===========================================
Files 495 493 -2
Lines 42539 42527 -12
===========================================
- Hits 33178 32867 -311
- Misses 9361 9660 +299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tests/actions/test_core_actions.py
Outdated
| @@ -533,39 +533,51 @@ def test_SlackNotificationAction_run(self, checkpoint_result: CheckpointResult): | |||
| with mock.patch.object(Session, "post") as mock_post: | |||
| output = action.run(checkpoint_result=checkpoint_result) | |||
|
|
|||
| assert mock_post.call_count == 5 # Sent in batches | |||
| assert mock_post.call_count == 1 | |||
| mock_post.assert_called_with( | |||
There was a problem hiding this comment.
assert_called_once_with seems like the most descriptive way to do this, rather than also use the call count
| payload["text"] = batch | ||
| result = self._get_slack_result(payload) | ||
| return result | ||
|
|
||
| def _get_slack_result(self, payload): |
There was a problem hiding this comment.
I know you didn't change it in this PR, but this is method should be renamed. Might as well do it now?
tyler-hoffman
approved these changes
May 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing duplicative Slack posts from our current logic - this should resolve the matter
What it should now look like:
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!