[MAINTENANCE] Instrument validation workflows #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9889 +/- ##
===========================================
+ Coverage 77.94% 77.96% +0.02%
===========================================
Files 493 493
Lines 42432 42479 +47
===========================================
+ Hits 33073 33120 +47
Misses 9359 9359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…_expectations into m/v1-196/validation_workflows_instrumentation
cdkini
commented
May 7, 2024
Comment on lines
48
to
54
| obj = self._get(key=key) | ||
|
|
||
| submit_event( | ||
| event=CheckpointCreatedEvent( | ||
| checkpoint_id=obj.id, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
This currently round trips so the actual object is different - a subtle difference from other stores (that might directly add the ID to the input object)
billdirks
reviewed
May 7, 2024
…_expectations into m/v1-196/validation_workflows_instrumentation
tyler-hoffman
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add analytics to checkpoint and validation definition factories (parity with existing suite factory).
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!