Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Rename core partitioners #9894

Merged
merged 8 commits into from
May 7, 2024

Conversation

joshua-stauffer
Copy link
Member

This PR updates the naming of partitioners in great_expectations.core.partitioners to follow a consistent convention. Partitioners which split on columns are renamed to ColumnPartitionerYearly/Monthly/Daily, and RegexPartitioners are renamed to FilePartitioner.

Copy link

netlify bot commented May 7, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 1b16d68
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663a97e3094ce10008c86ab1
😎 Deploy Preview https://deploy-preview-9894.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.94%. Comparing base (aad13e6) to head (1b16d68).

Files Patch % Lines
.../fluent/data_connector/file_path_data_connector.py 0.00% 1 Missing ⚠️
...pectations/datasource/fluent/invalid_datasource.py 50.00% 1 Missing ⚠️
...xpectations/datasource/fluent/pandas_datasource.py 0.00% 1 Missing ⚠️
...expectations/datasource/fluent/spark_datasource.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9894   +/-   ##
========================================
  Coverage    77.94%   77.94%           
========================================
  Files          494      494           
  Lines        42440    42440           
========================================
  Hits         33080    33080           
  Misses        9360     9360           
Flag Coverage Δ
3.10 64.33% <80.00%> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 64.33% <80.00%> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.10% <80.00%> (ø)
3.11 aws_deps 45.01% <80.00%> (ø)
3.11 big 55.97% <80.00%> (ø)
3.11 databricks 46.18% <80.00%> (ø)
3.11 filesystem 60.92% <80.00%> (ø)
3.11 mssql 48.98% <80.00%> (ø)
3.11 mysql 49.04% <80.00%> (ø)
3.11 postgresql 52.88% <84.00%> (ø)
3.11 snowflake 46.79% <80.00%> (-0.01%) ⬇️
3.11 spark 57.48% <80.00%> (ø)
3.11 trino 50.96% <80.00%> (ø)
3.8 64.35% <80.00%> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.11% <80.00%> (ø)
3.8 aws_deps 45.02% <80.00%> (ø)
3.8 big 55.98% <80.00%> (ø)
3.8 databricks 46.20% <80.00%> (ø)
3.8 filesystem 60.93% <80.00%> (ø)
3.8 mssql 48.97% <80.00%> (ø)
3.8 mysql 49.02% <80.00%> (ø)
3.8 postgresql 52.86% <84.00%> (ø)
3.8 snowflake 46.81% <80.00%> (ø)
3.8 spark 57.44% <80.00%> (ø)
3.8 trino 50.94% <80.00%> (ø)
3.9 64.35% <80.00%> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 filesystem ?
3.9 mysql ?
3.9 postgresql ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <0.00%> (ø)
docs-basic 49.03% <80.00%> (ø)
docs-creds-needed 50.46% <80.00%> (ø)
docs-spark 48.55% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshua-stauffer joshua-stauffer added this pull request to the merge queue May 7, 2024
Merged via the queue into develop with commit c091b36 May 7, 2024
68 checks passed
@joshua-stauffer joshua-stauffer deleted the m/v1-306/rename_partitioners branch May 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants