Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Ensure that actions have names #9902

Merged
merged 2 commits into from
May 8, 2024

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented May 8, 2024

To be able to discern between different actions of the same type, we need to support names - these will be used in the Cloud UI

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@cdkini cdkini self-assigned this May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 876a8bf
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663bd4a1970d3d00080b06ae

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.38%. Comparing base (b43a45f) to head (876a8bf).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9902   +/-   ##
========================================
  Coverage    77.38%   77.38%           
========================================
  Files          493      493           
  Lines        42036    42037    +1     
========================================
+ Hits         32531    32532    +1     
  Misses        9505     9505           
Flag Coverage Δ
3.10 63.92% <100.00%> (+<0.01%) ⬆️
3.11 63.92% <100.00%> (+<0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.75% <100.00%> (+<0.01%) ⬆️
3.11 aws_deps 44.75% <100.00%> (+<0.01%) ⬆️
3.11 big 54.20% <100.00%> (+<0.01%) ⬆️
3.11 databricks 45.89% <100.00%> (+<0.01%) ⬆️
3.11 filesystem 59.15% <100.00%> (+<0.01%) ⬆️
3.11 mssql 48.73% <100.00%> (+<0.01%) ⬆️
3.11 mysql ?
3.11 postgresql 52.65% <100.00%> (+<0.01%) ⬆️
3.11 snowflake 46.53% <100.00%> (+<0.01%) ⬆️
3.11 spark 56.28% <100.00%> (+<0.01%) ⬆️
3.11 trino 50.71% <100.00%> (+<0.01%) ⬆️
3.8 63.95% <100.00%> (+<0.01%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.76% <100.00%> (+<0.01%) ⬆️
3.8 aws_deps 44.77% <100.00%> (+<0.01%) ⬆️
3.8 big 54.21% <100.00%> (+<0.01%) ⬆️
3.8 databricks 45.91% <100.00%> (+<0.01%) ⬆️
3.8 filesystem 59.16% <100.00%> (+<0.01%) ⬆️
3.8 mssql 48.71% <100.00%> (+<0.01%) ⬆️
3.8 mysql 48.76% <100.00%> (+<0.01%) ⬆️
3.8 postgresql 52.64% <100.00%> (+<0.01%) ⬆️
3.8 snowflake 46.54% <100.00%> (-0.01%) ⬇️
3.8 spark 56.24% <100.00%> (+<0.01%) ⬆️
3.8 trino 50.70% <100.00%> (+<0.01%) ⬆️
3.9 63.94% <100.00%> (+<0.01%) ⬆️
cloud 0.00% <0.00%> (ø)
docs-basic 47.36% <100.00%> (+<0.01%) ⬆️
docs-creds-needed 48.40% <100.00%> (+<0.01%) ⬆️
docs-spark 47.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdkini cdkini enabled auto-merge May 8, 2024 19:42
@cdkini cdkini added this pull request to the merge queue May 8, 2024
Merged via the queue into develop with commit 97902d9 May 8, 2024
69 checks passed
@cdkini cdkini deleted the m/v1-332/add_names_to_actions branch May 8, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants