Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Change the texts of the "Was this Helpful?" widget #9905

Merged
merged 2 commits into from
May 9, 2024

Conversation

deborahniesz
Copy link
Contributor

@deborahniesz deborahniesz commented May 8, 2024

Deploy Preview

Jira Ticket

Description

Changes consist of:

Replace
Was this helpful?
with
Was this topic helpful?

Replace
Your opinion matters. Share your feedback here to help us improve the quality of our documentation and ensure a better user experience. Thank you for taking the time to share your experience.
with
If you’re not reporting documentation issues such as typos, missing content, or inaccuracies, post your comments or feedback on Discourse. Thank you for helping us improve our documentation.

Replace
Provide as much detail as possible about the issue you experienced or where improvement is needed. Detailed feedback helps us better identify the problem and determine a solution.
with
Provide as much detail as possible about the documentation issue you experienced. Detailed feedback helps us get the documentation updated quickly.

Before

image

After

image

Before

image

After

image

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented May 8, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit dca45f2
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663d19894e92aa000949c08a
😎 Deploy Preview https://deploy-preview-9905.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.28%. Comparing base (97902d9) to head (dca45f2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9905      +/-   ##
===========================================
- Coverage    77.38%   77.28%   -0.11%     
===========================================
  Files          493      492       -1     
  Lines        42037    42006      -31     
===========================================
- Hits         32532    32465      -67     
- Misses        9505     9541      +36     
Flag Coverage Δ
3.10 63.73% <ø> (-0.20%) ⬇️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 63.73% <ø> (-0.20%) ⬇️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.63% <ø> (-0.12%) ⬇️
3.11 aws_deps 44.77% <ø> (+0.01%) ⬆️
3.11 big 54.22% <ø> (+0.02%) ⬆️
3.11 databricks 45.91% <ø> (+0.01%) ⬆️
3.11 filesystem 59.17% <ø> (+0.02%) ⬆️
3.11 mssql 48.74% <ø> (+0.01%) ⬆️
3.11 mysql 48.80% <ø> (+0.01%) ⬆️
3.11 postgresql 52.67% <ø> (+0.01%) ⬆️
3.11 snowflake 46.54% <ø> (+0.01%) ⬆️
3.11 spark 56.30% <ø> (+0.02%) ⬆️
3.11 trino 50.73% <ø> (+0.01%) ⬆️
3.8 63.75% <ø> (-0.20%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.64% <ø> (-0.12%) ⬇️
3.8 aws_deps 44.78% <ø> (+0.01%) ⬆️
3.8 big 54.23% <ø> (+0.02%) ⬆️
3.8 databricks 45.92% <ø> (+0.01%) ⬆️
3.8 filesystem 59.18% <ø> (+0.02%) ⬆️
3.8 mssql 48.72% <ø> (+0.01%) ⬆️
3.8 mysql 48.78% <ø> (+0.01%) ⬆️
3.8 postgresql 52.66% <ø> (+0.01%) ⬆️
3.8 snowflake 46.55% <ø> (+0.01%) ⬆️
3.8 spark 56.27% <ø> (+0.02%) ⬆️
3.8 trino 50.72% <ø> (+0.01%) ⬆️
3.9 63.75% <ø> (-0.20%) ⬇️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 47.37% <ø> (+0.01%) ⬆️
docs-creds-needed 48.42% <ø> (+0.01%) ⬆️
docs-spark 47.09% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Specified "code inaccuracies"

Co-authored-by: Rob Gray <104205257+kwcanuck@users.noreply.github.com>
@deborahniesz deborahniesz added this pull request to the merge queue May 9, 2024
Merged via the queue into develop with commit ed3b5b4 May 9, 2024
63 checks passed
@deborahniesz deborahniesz deleted the DSB-866_update_text_of_feedback_modal branch May 9, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants