Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Improve error message around instantiating and saving s… #9908

Merged
merged 2 commits into from
May 9, 2024

Conversation

tyler-hoffman
Copy link
Contributor

@tyler-hoffman tyler-hoffman commented May 9, 2024

…uites

Main stuff

Other stuff

  • Updates set_context to allow None values. I think this is desirable to test specific cases like this, and it's not part of the public api, so it should only be used internally.
  • There's a comment above the updated Exception about how we are clobbering errors from the store. I considered changing the logic so that we check in the suite if it has been persisted and raise there, but that introduces a race condition, and I think we mostly need to solve for the normal use case.
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented May 9, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 71f606b
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663ce401f5b7000008612027

@tyler-hoffman tyler-hoffman force-pushed the f/v1-240/better-error-on-suite-save branch from 59f857c to a417c90 Compare May 9, 2024 14:50
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.28%. Comparing base (77fc8e9) to head (71f606b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9908      +/-   ##
===========================================
+ Coverage    77.27%   77.28%   +0.01%     
===========================================
  Files          492      492              
  Lines        41999    42006       +7     
===========================================
+ Hits         32455    32465      +10     
+ Misses        9544     9541       -3     
Flag Coverage Δ
3.10 63.73% <100.00%> (+0.01%) ⬆️
3.11 63.73% <100.00%> (+0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.63% <54.54%> (+<0.01%) ⬆️
3.11 aws_deps 44.77% <54.54%> (+<0.01%) ⬆️
3.11 big 54.22% <54.54%> (+<0.01%) ⬆️
3.11 databricks 45.91% <54.54%> (+<0.01%) ⬆️
3.11 filesystem 59.17% <54.54%> (+<0.01%) ⬆️
3.11 mssql 48.74% <54.54%> (+<0.01%) ⬆️
3.11 mysql 48.80% <54.54%> (+<0.01%) ⬆️
3.11 postgresql 52.67% <54.54%> (+<0.01%) ⬆️
3.11 snowflake 46.54% <54.54%> (+<0.01%) ⬆️
3.11 spark 56.30% <54.54%> (+<0.01%) ⬆️
3.11 trino 50.73% <54.54%> (+<0.01%) ⬆️
3.8 63.75% <100.00%> (+0.01%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.64% <54.54%> (+<0.01%) ⬆️
3.8 aws_deps 44.78% <54.54%> (+<0.01%) ⬆️
3.8 big 54.23% <54.54%> (+<0.01%) ⬆️
3.8 databricks 45.92% <54.54%> (+<0.01%) ⬆️
3.8 filesystem 59.18% <54.54%> (+<0.01%) ⬆️
3.8 mssql 48.72% <54.54%> (+<0.01%) ⬆️
3.8 mysql 48.78% <54.54%> (+<0.01%) ⬆️
3.8 postgresql 52.66% <54.54%> (+<0.01%) ⬆️
3.8 snowflake 46.55% <54.54%> (+<0.01%) ⬆️
3.8 spark 56.27% <54.54%> (+<0.01%) ⬆️
3.8 trino 50.72% <54.54%> (+<0.01%) ⬆️
3.9 63.75% <100.00%> (+0.01%) ⬆️
cloud 0.00% <0.00%> (ø)
docs-basic 47.37% <54.54%> (+<0.01%) ⬆️
docs-creds-needed 48.42% <54.54%> (+<0.01%) ⬆️
docs-spark 47.09% <54.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyler-hoffman tyler-hoffman added this pull request to the merge queue May 9, 2024
Merged via the queue into develop with commit c8e30f3 May 9, 2024
69 checks passed
@tyler-hoffman tyler-hoffman deleted the f/v1-240/better-error-on-suite-save branch May 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants