[MAINTENANCE] Ruff 0.4.4

[Kilo59]

Update version of ruff

1. https://github.com/astral-sh/ruff/releases/tag/v0.4.3
2. https://github.com/astral-sh/ruff/releases/tag/v0.4.4

[netlify]

✅ Deploy Preview for niobium-lead-7998 canceled.

Name	Link
🔨 Latest commit	2dc82ba
🔍 Latest deploy log	https://app.netlify.com/sites/niobium-lead-7998/deploys/664221d5a98a7f0008044978

[netlify]

✅ Deploy Preview for niobium-lead-7998 canceled.

Name	Link
🔨 Latest commit	6f094f5
🔍 Latest deploy log	https://app.netlify.com/sites/niobium-lead-7998/deploys/664226533c87020008b86cbb

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.24%. Comparing base (4b7aec0) to head (6f094f5).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #9918   +/-   ##
========================================
  Coverage    77.24%   77.24%           
========================================
  Files          491      491           
  Lines        41817    41817           
========================================
  Hits         32300    32300           
  Misses        9517     9517           

Flag	Coverage Δ
3.10	63.53% <100.00%> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds	?
3.10 aws_deps	?
3.10 big	?
3.10 databricks	?
3.10 filesystem	?
3.10 mssql	?
3.10 mysql	?
3.10 postgresql	?
3.10 snowflake	?
3.10 spark	?
3.10 trino	?
3.11	63.53% <100.00%> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds	53.67% <100.00%> (ø)
3.11 aws_deps	44.73% <100.00%> (ø)
3.11 big	54.24% <100.00%> (ø)
3.11 databricks	45.91% <100.00%> (ø)
3.11 filesystem	59.02% <100.00%> (ø)
3.11 mssql	48.78% <100.00%> (ø)
3.11 mysql	48.83% <100.00%> (ø)
3.11 postgresql	52.70% <100.00%> (ø)
3.11 snowflake	46.55% <100.00%> (-0.01%)	⬇️
3.11 spark	56.29% <100.00%> (ø)
3.11 trino	50.76% <100.00%> (ø)
3.8	63.55% <100.00%> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds	53.67% <100.00%> (ø)
3.8 aws_deps	44.74% <100.00%> (ø)
3.8 big	54.25% <100.00%> (ø)
3.8 databricks	45.93% <100.00%> (ø)
3.8 filesystem	59.03% <100.00%> (ø)
3.8 mssql	48.76% <100.00%> (ø)
3.8 mysql	48.81% <100.00%> (ø)
3.8 postgresql	52.68% <100.00%> (ø)
3.8 snowflake	46.56% <100.00%> (-0.01%)	⬇️
3.8 spark	56.26% <100.00%> (ø)
3.8 trino	50.74% <100.00%> (ø)
3.9	63.54% <100.00%> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds	?
3.9 aws_deps	?
3.9 big	?
3.9 databricks	?
3.9 filesystem	?
3.9 mssql	?
3.9 mysql	?
3.9 postgresql	?
3.9 snowflake	?
3.9 spark	?
3.9 trino	?
cloud	0.00% <0.00%> (ø)
docs-basic	47.43% <100.00%> (ø)
docs-creds-needed	48.50% <100.00%> (ø)
docs-spark	47.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Kilo59]

I think the violation is understandable given we do need this class to be inherited and never instantied directly.

A Protocal with default methods COULD also work here (or having a distinct Protocol + a DataPartitionerBase), but these don't seem obviously better to me.

I think this is the exception that proves the rule.

https://docs.astral.sh/ruff/rules/abstract-base-class-without-abstract-method/

abstract-base-class-without-abstract-method (B024)

Derived from the flake8-bugbear linter.

What it does

Checks for abstract classes without abstract methods.

Why is this bad?

Abstract base classes are used to define interfaces. If an abstract base
class has no abstract methods, you may have forgotten to add an abstract
method to the class or omitted an @abstractmethod decorator.

If the class is not meant to be used as an interface, consider removing
the ABC base class from the class definition.

Example

from abc import ABC


class Foo(ABC):
    def method(self):
        bar()

Use instead:

from abc import ABC, abstractmethod


class Foo(ABC):
    @abstractmethod
    def method(self):
        bar()

References

• Python documentation: abc

[tyler-hoffman]

I'm fine with it as is, even though ABCs without abstractmethods can be instantiated directly. We could also do something like suggested here, but I think it should be apparent to readers that they shouldn't directly instantiate this, which is the most important thin IMO