Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Remove legacy DataConnectors #9923

Merged
merged 28 commits into from
May 14, 2024

fix indent error

8708885
Select commit
Loading
Failed to load commit list.
Merged

[MAINTENANCE] Remove legacy DataConnectors #9923

fix indent error
8708885
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 14, 2024 in 0s

77.79% (+0.46%) compared to 9c9d551

View this Pull Request on Codecov

77.79% (+0.46%) compared to 9c9d551

Details

Codecov Report

Attention: Patch coverage is 81.42857% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 77.79%. Comparing base (9c9d551) to head (8708885).
Report is 2 commits behind head on develop.

Files Patch % Lines
...asource/fluent/data_connector/s3_data_connector.py 76.92% 6 Missing ⚠️
...a_connector/google_cloud_storage_data_connector.py 70.58% 5 Missing ⚠️
.../fluent/data_connector/file_path_data_connector.py 92.59% 4 Missing ⚠️
...fluent/data_connector/filesystem_data_connector.py 78.57% 3 Missing ⚠️
...ata_connector/azure_blob_storage_data_connector.py 90.00% 2 Missing ⚠️
great_expectations/core/batch.py 0.00% 1 Missing ⚠️
...tasource/fluent/data_asset/path/directory_asset.py 0.00% 1 Missing ⚠️
...ns/datasource/fluent/data_asset/path/file_asset.py 0.00% 1 Missing ⚠️
great_expectations/datasource/fluent/interfaces.py 0.00% 1 Missing ⚠️
...xpectations/datasource/fluent/pandas_datasource.py 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9923      +/-   ##
===========================================
+ Coverage    77.33%   77.79%   +0.46%     
===========================================
  Files          490      456      -34     
  Lines        41659    39630    -2029     
===========================================
- Hits         32218    30832    -1386     
+ Misses        9441     8798     -643

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov