Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Minor Edits to Connect GX Cloud to PostgreSQL (GX Cloud) #9927

Merged
merged 1 commit into from
May 14, 2024

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented May 14, 2024

In this Slack conversation, @joshzzheng identified an issue with the connection string example provided in step 6 of Connect to a PostgreSQL Data Asset. This PR implements the necessary edit.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented May 14, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 7327a2b
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6643657fb291d600082126c5
😎 Deploy Preview https://deploy-preview-9927.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (9c9d551) to head (7327a2b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9927      +/-   ##
===========================================
- Coverage    77.33%   77.29%   -0.04%     
===========================================
  Files          490      490              
  Lines        41659    41659              
===========================================
- Hits         32218    32202      -16     
- Misses        9441     9457      +16     
Flag Coverage Δ
3.10 63.57% <ø> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 63.57% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.68% <ø> (ø)
3.11 aws_deps 44.71% <ø> (ø)
3.11 big 54.26% <ø> (ø)
3.11 databricks 45.90% <ø> (ø)
3.11 filesystem 59.06% <ø> (ø)
3.11 mssql 48.78% <ø> (ø)
3.11 mysql 48.83% <ø> (ø)
3.11 postgresql 52.71% <ø> (ø)
3.11 snowflake ?
3.11 spark 56.32% <ø> (ø)
3.11 trino 50.77% <ø> (ø)
3.8 63.59% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.69% <ø> (ø)
3.8 aws_deps 44.73% <ø> (ø)
3.8 big 54.27% <ø> (ø)
3.8 databricks 45.92% <ø> (ø)
3.8 filesystem 59.07% <ø> (ø)
3.8 mssql 48.76% <ø> (ø)
3.8 mysql 48.82% <ø> (ø)
3.8 postgresql 52.70% <ø> (ø)
3.8 snowflake ?
3.8 spark 56.28% <ø> (ø)
3.8 trino 50.75% <ø> (ø)
3.9 63.59% <ø> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 47.43% <ø> (ø)
docs-creds-needed 48.50% <ø> (ø)
docs-spark 47.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwcanuck kwcanuck added this pull request to the merge queue May 14, 2024
Merged via the queue into develop with commit c11faff May 14, 2024
65 checks passed
@kwcanuck kwcanuck deleted the postgresql-update branch May 14, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants