Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove batch kwargs #9932

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

joshua-stauffer
Copy link
Member

This PR removes the last of BatchKwargs, which are unused but still defined.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 589e132
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6644f35e17a8430008efc344

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (27eb8d2) to head (589e132).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9932      +/-   ##
===========================================
+ Coverage    77.83%   77.85%   +0.01%     
===========================================
  Files          456      454       -2     
  Lines        39606    39523      -83     
===========================================
- Hits         30827    30770      -57     
+ Misses        8779     8753      -26     
Flag Coverage Δ
3.10 64.39% <ø> (-0.01%) ⬇️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 64.38% <ø> (-0.03%) ⬇️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.62% <ø> (-0.03%) ⬇️
3.11 aws_deps 44.79% <ø> (-0.05%) ⬇️
3.11 big 53.84% <ø> (-0.03%) ⬇️
3.11 databricks 46.08% <ø> (-0.04%) ⬇️
3.11 filesystem 59.33% <ø> (-0.02%) ⬇️
3.11 mssql 49.07% <ø> (-0.04%) ⬇️
3.11 mysql 49.13% <ø> (-0.04%) ⬇️
3.11 postgresql 53.25% <ø> (-0.03%) ⬇️
3.11 snowflake 46.75% <ø> (-0.04%) ⬇️
3.11 spark 56.52% <ø> (-0.02%) ⬇️
3.11 trino 51.17% <ø> (-0.03%) ⬇️
3.8 64.42% <ø> (-0.01%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.63% <ø> (-0.03%) ⬇️
3.8 aws_deps 44.81% <ø> (-0.05%) ⬇️
3.8 big 53.85% <ø> (-0.03%) ⬇️
3.8 databricks 46.09% <ø> (-0.04%) ⬇️
3.8 filesystem 59.35% <ø> (-0.02%) ⬇️
3.8 mssql 49.05% <ø> (-0.04%) ⬇️
3.8 mysql 49.11% <ø> (-0.04%) ⬇️
3.8 postgresql 53.24% <ø> (-0.03%) ⬇️
3.8 snowflake 46.76% <ø> (-0.05%) ⬇️
3.8 spark 56.49% <ø> (-0.02%) ⬇️
3.8 trino 51.15% <ø> (-0.03%) ⬇️
3.9 64.41% <ø> (-0.01%) ⬇️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 47.62% <ø> (+0.09%) ⬆️
docs-creds-needed 48.74% <ø> (+0.10%) ⬆️
docs-spark 47.47% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshua-stauffer joshua-stauffer added this pull request to the merge queue May 15, 2024
Copy link
Member

@Kilo59 Kilo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ This one was also giving me trouble so thank you for this!

Merged via the queue into develop with commit 61d25de May 15, 2024
69 checks passed
@joshua-stauffer joshua-stauffer deleted the m/v1/remove_batch_kwargs branch May 15, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants