-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Move convert_to_json_serializable
to top-level utils package
#9933
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9933 +/- ##
========================================
Coverage 77.85% 77.85%
========================================
Files 454 454
Lines 39523 39517 -6
========================================
- Hits 30770 30766 -4
+ Misses 8753 8751 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
...ions/creating_custom_expectations/expect_queried_column_value_frequency_to_meet_threshold.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, except for the doc changes that @cdkini mentioned and the test you noted you should move.
Thanks for doing this!
Move
convert_to_json_serializable
to the top-level utils package.Nesting it within
core.utils
causes a lot of avoidable import cycles.