Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Move convert_to_json_serializable to top-level utils package #9933

Merged
merged 12 commits into from
May 15, 2024

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented May 15, 2024

Move convert_to_json_serializable to the top-level utils package.
Nesting it within core.utils causes a lot of avoidable import cycles.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 31eab4d
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6645324076c4560007d80e72
😎 Deploy Preview https://deploy-preview-9933.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 79.63801% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 77.85%. Comparing base (1c0c2cb) to head (31eab4d).

Files Patch % Lines
great_expectations/util.py 76.50% 43 Missing ⚠️
great_expectations/core/util.py 50.00% 1 Missing ⚠️
...rule_based_profiler/helpers/runtime_environment.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9933   +/-   ##
========================================
  Coverage    77.85%   77.85%           
========================================
  Files          454      454           
  Lines        39523    39517    -6     
========================================
- Hits         30770    30766    -4     
+ Misses        8753     8751    -2     
Flag Coverage Δ
3.10 64.39% <76.01%> (-0.01%) ⬇️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 64.39% <76.01%> (+0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.62% <64.70%> (-0.01%) ⬇️
3.11 aws_deps 44.79% <59.72%> (-0.01%) ⬇️
3.11 big 53.84% <71.04%> (-0.01%) ⬇️
3.11 databricks 46.07% <61.08%> (-0.01%) ⬇️
3.11 filesystem 59.33% <70.58%> (-0.01%) ⬇️
3.11 mssql 49.06% <60.18%> (-0.01%) ⬇️
3.11 mysql 49.12% <63.34%> (-0.01%) ⬇️
3.11 postgresql 53.25% <65.61%> (-0.01%) ⬇️
3.11 snowflake 46.74% <61.08%> (-0.01%) ⬇️
3.11 spark 56.52% <68.32%> (-0.01%) ⬇️
3.11 trino 51.16% <65.15%> (-0.01%) ⬇️
3.8 64.42% <76.01%> (-0.01%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.62% <64.70%> (-0.01%) ⬇️
3.8 aws_deps 44.81% <59.72%> (-0.01%) ⬇️
3.8 big 53.85% <71.04%> (-0.01%) ⬇️
3.8 databricks 46.09% <61.08%> (-0.01%) ⬇️
3.8 filesystem 59.34% <70.58%> (-0.01%) ⬇️
3.8 mssql 49.04% <60.18%> (-0.01%) ⬇️
3.8 mysql 49.10% <63.34%> (-0.01%) ⬇️
3.8 postgresql 53.24% <65.61%> (-0.01%) ⬇️
3.8 snowflake 46.76% <61.08%> (-0.01%) ⬇️
3.8 spark 56.48% <68.32%> (-0.01%) ⬇️
3.8 trino 51.15% <65.15%> (-0.01%) ⬇️
3.9 64.41% <76.01%> (-0.01%) ⬇️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <0.00%> (ø)
docs-basic 47.62% <56.56%> (+<0.01%) ⬆️
docs-creds-needed 48.74% <56.10%> (+<0.01%) ⬆️
docs-spark 47.47% <56.10%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kilo59 Kilo59 self-assigned this May 15, 2024
@Kilo59 Kilo59 marked this pull request as ready for review May 15, 2024 19:10
Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, except for the doc changes that @cdkini mentioned and the test you noted you should move.

Thanks for doing this!

tests/core/test_convert_to_json_serializable.py Outdated Show resolved Hide resolved
@Kilo59 Kilo59 enabled auto-merge May 15, 2024 22:08
@Kilo59 Kilo59 added this pull request to the merge queue May 15, 2024
Merged via the queue into develop with commit 499430b May 15, 2024
69 checks passed
@Kilo59 Kilo59 deleted the m/_/utils_move branch May 15, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants