Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] fix exception when attempting to write to read only file system #9945

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

javier5109
Copy link

@javier5109 javier5109 commented May 17, 2024

Description

  • adds OSError to exception list to allow great expectations to by pass writing to great_expectations.yml file. This is relevant to MWAA read-only task workers.
  • would be nice to be added to older 0.18.x versions

Link to issue
#9911

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented May 17, 2024

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 853a07c

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (4a6c924) to head (853a07c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9945      +/-   ##
===========================================
- Coverage    79.07%   73.16%   -5.92%     
===========================================
  Files          454      454              
  Lines        38475    38475              
===========================================
- Hits         30425    28149    -2276     
- Misses        8050    10326    +2276     
Flag Coverage Δ
3.10 65.30% <0.00%> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 65.30% <0.00%> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.10% <0.00%> (ø)
3.11 aws_deps 45.25% <0.00%> (ø)
3.11 big 54.17% <0.00%> (-0.05%) ⬇️
3.11 databricks 42.03% <0.00%> (-4.35%) ⬇️
3.11 filesystem 60.05% <100.00%> (ø)
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 trino ?
3.8 65.32% <0.00%> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.11% <0.00%> (ø)
3.8 aws_deps 45.27% <0.00%> (ø)
3.8 big 54.19% <0.00%> (-0.05%) ⬇️
3.8 databricks 42.04% <0.00%> (-4.35%) ⬇️
3.8 filesystem 60.06% <100.00%> (ø)
3.8 mssql ?
3.8 mysql ?
3.8 postgresql ?
3.8 snowflake ?
3.8 spark ?
3.8 trino ?
3.9 65.32% <0.00%> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 spark ?
3.9 trino ?
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kilo59
Copy link
Member

Kilo59 commented May 17, 2024

Thanks for this @javier5109.
The Snowflake test failure isn't something you'll be able to do anything about.
It may be a while before we can get this merged.

@Kilo59
Copy link
Member

Kilo59 commented May 24, 2024

@javier5109 We still need to do some work to fix the snowflake tests to run (or skip) for contributors.

In the meantime, I'm going to merge a copy of this fix to our older 0.18.x branch.

Once we fix our CI, I'll merge this into our develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants