-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Show FDS Asset name in DataDocs #9953
base: develop
Are you sure you want to change the base?
Conversation
Kilo59
commented
May 22, 2024
•
edited
Loading
edited
- V1 version of [BUGFIX] Show FDS Asset name in DataDocs #9950
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9953 +/- ##
============================================
- Coverage 79.44% 66.04% -13.41%
============================================
Files 456 454 -2
Lines 39767 39773 +6
============================================
- Hits 31593 26267 -5326
- Misses 8174 13506 +5332 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
asset_name = "my_asset" | ||
validator = context.data_sources.pandas_default.read_csv( | ||
"https://raw.githubusercontent.com/great-expectations/gx_tutorials/main/data/yellow_tripdata_sample_2019-01.csv", | ||
asset_name=asset_name, | ||
) | ||
|
||
validator.expect_column_values_to_not_be_null("pickup_datetime") | ||
validator.expect_column_values_to_be_between("passenger_count", min_value=1, max_value=6) | ||
validator.save_expectation_suite(discard_failed_expectations=False) | ||
|
||
checkpoint = context.add_or_update_checkpoint( | ||
name="my_quickstart_checkpoint", | ||
validator=validator, | ||
) | ||
|
||
checkpoint.run() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the equivalent quickstart for running a checkpoint in v1?
Edit:
Going with this
https://docs.greatexpectations.io/docs/1.0-prerelease/core/introduction/try_gx
@@ -2091,7 +2097,7 @@ def get_validation_result( # noqa: C901, PLR0913 | |||
batch_identifier=None, | |||
validation_results_store_name=None, | |||
failed_only=False, | |||
): | |||
) -> ExpectationValidationResult | dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) -> ExpectationValidationResult | dict: | |
) -> ExpectationValidationResult: |