Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Show FDS Asset name in DataDocs #9953

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented May 22, 2024

Copy link

netlify bot commented May 22, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 4d297c1
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6697bd2255a34100085284e3

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 66.04%. Comparing base (ed21462) to head (4d297c1).

Files Patch % Lines
great_expectations/render/renderer/site_builder.py 22.22% 7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ed21462) and HEAD (4d297c1). Click for more details.

HEAD has 146 uploads less than BASE
Flag BASE (ed21462) HEAD (4d297c1)
3.11 4 1
3.8 4 1
3.10 4 1
3.12 4 1
3.9 4 1
3.8 big 4 0
3.8 aws_deps 4 0
3.12 big 4 0
3.12 aws_deps 4 0
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 3 0
3.8 filesystem 3 0
3.12 mysql 3 0
docs-creds-needed 1 0
3.8 postgresql 3 0
3.12 postgresql 3 0
docs-basic 1 0
3.8 mssql 3 0
cloud 1 0
3.12 mssql 3 0
3.8 databricks 3 0
3.8 trino 3 0
3.12 trino 3 0
3.8 snowflake 3 0
3.8 mysql 3 0
docs-spark 1 0
3.8 spark 3 0
3.12 spark 3 0
3.9 big 3 0
3.9 aws_deps 3 0
3.10 aws_deps 3 0
3.11 aws_deps 3 0
3.11 filesystem 2 0
3.10 filesystem 2 0
3.9 filesystem 2 0
3.12 filesystem 3 0
3.11 mysql 2 0
3.10 mysql 2 0
3.11 databricks 2 0
3.10 databricks 2 0
3.9 mysql 2 0
3.10 postgresql 2 0
3.9 postgresql 2 0
3.11 mssql 2 0
3.9 mssql 2 0
3.11 postgresql 2 0
3.11 trino 2 0
3.9 snowflake 2 0
3.10 trino 2 0
3.11 snowflake 2 0
3.9 trino 2 0
3.10 snowflake 2 0
3.9 databricks 2 0
3.10 mssql 2 0
3.9 spark 2 0
3.11 spark 2 0
3.10 spark 2 0
3.10 big 3 0
3.11 big 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9953       +/-   ##
============================================
- Coverage    79.44%   66.04%   -13.41%     
============================================
  Files          456      454        -2     
  Lines        39767    39773        +6     
============================================
- Hits         31593    26267     -5326     
- Misses        8174    13506     +5332     
Flag Coverage Δ
3.10 66.02% <22.22%> (+<0.01%) ⬆️
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 66.02% <22.22%> (-0.01%) ⬇️
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 trino ?
3.12 64.57% <22.22%> (-0.02%) ⬇️
3.12 aws_deps ?
3.12 big ?
3.12 filesystem ?
3.12 mssql ?
3.12 mysql ?
3.12 postgresql ?
3.12 spark ?
3.12 trino ?
3.8 66.04% <22.22%> (-0.03%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.8 aws_deps ?
3.8 big ?
3.8 databricks ?
3.8 filesystem ?
3.8 mssql ?
3.8 mysql ?
3.8 postgresql ?
3.8 snowflake ?
3.8 spark ?
3.8 trino ?
3.9 66.03% <22.22%> (-0.02%) ⬇️
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kilo59 Kilo59 self-assigned this May 22, 2024
Comment on lines +562 to +577
asset_name = "my_asset"
validator = context.data_sources.pandas_default.read_csv(
"https://raw.githubusercontent.com/great-expectations/gx_tutorials/main/data/yellow_tripdata_sample_2019-01.csv",
asset_name=asset_name,
)

validator.expect_column_values_to_not_be_null("pickup_datetime")
validator.expect_column_values_to_be_between("passenger_count", min_value=1, max_value=6)
validator.save_expectation_suite(discard_failed_expectations=False)

checkpoint = context.add_or_update_checkpoint(
name="my_quickstart_checkpoint",
validator=validator,
)

checkpoint.run()
Copy link
Member Author

@Kilo59 Kilo59 May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the equivalent quickstart for running a checkpoint in v1?

Edit:
Going with this
https://docs.greatexpectations.io/docs/1.0-prerelease/core/introduction/try_gx

@@ -2091,7 +2097,7 @@ def get_validation_result( # noqa: C901, PLR0913
batch_identifier=None,
validation_results_store_name=None,
failed_only=False,
):
) -> ExpectationValidationResult | dict:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
) -> ExpectationValidationResult | dict:
) -> ExpectationValidationResult:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant