Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add NumberControl and NumericControl tests #17

Merged
merged 40 commits into from
Mar 6, 2024
Merged

feat: Add NumberControl and NumericControl tests #17

merged 40 commits into from
Mar 6, 2024

Conversation

NathanFarmer
Copy link
Contributor

@NathanFarmer NathanFarmer commented Mar 1, 2024 •
edited
Loading

Corresponding functional changes are in base branch

Add tests for NumberControl and related components/functions.

@NathanFarmer NathanFarmer self-assigned this Mar 1, 2024
@NathanFarmer NathanFarmer changed the base branch from main to f/FE-48/number-renderer March 1, 2024 16:39
@NathanFarmer NathanFarmer changed the base branch from f/FE-48/number-renderer to main March 1, 2024 16:41
@NathanFarmer NathanFarmer changed the base branch from main to f/FE-48/number-renderer March 1, 2024 16:49
@NathanFarmer NathanFarmer changed the base branch from f/FE-48/number-renderer to main March 1, 2024 16:51
@NathanFarmer NathanFarmer changed the base branch from main to f/FE-48/number-renderer March 1, 2024 16:51
@NathanFarmer NathanFarmer marked this pull request as ready for review March 1, 2024 16:54
@NathanFarmer NathanFarmer changed the base branch from f/FE-48/number-renderer to main March 1, 2024 16:59
NathanFarmer
NathanFarmer commented Mar 1, 2024
View reviewed changes
tsconfig.production.json
@@ -3,7 +3,7 @@
"src"
],
"exclude": [
"**/*.test.tsx",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was attempting to bundle the .ts test file

@NathanFarmer NathanFarmer changed the base branch from main to f/FE-48/number-renderer March 1, 2024 18:52
@NathanFarmer NathanFarmer changed the base branch from f/FE-48/number-renderer to main March 1, 2024 18:52
@NathanFarmer NathanFarmer force-pushed the f/FE-48/number-renderer-tests branch from 73e441c to f8ecf51 Compare March 1, 2024 19:15
@NathanFarmer NathanFarmer changed the base branch from main to f/FE-48/number-renderer March 1, 2024 19:15
@NathanFarmer NathanFarmer marked this pull request as ready for review March 5, 2024 16:56
@NathanFarmer NathanFarmer marked this pull request as draft March 5, 2024 17:02
TrangPham
TrangPham reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@TrangPham TrangPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we want to put all the test code in a test dir so it's easier not to bundle them within the build? Or perhaps that doesn't matter?

@NathanFarmer NathanFarmer marked this pull request as ready for review March 5, 2024 18:41
Base automatically changed from f/FE-48/number-renderer to main March 5, 2024 19:43
@NathanFarmer
Copy link
Contributor Author

I'm wondering if we want to put all the test code in a test dir so it's easier not to bundle them within the build? Or perhaps that doesn't matter?

@TrangPham I don't think the bundling thing is much of a concern after the tsconfig change in this PR. Personally, I prefer to have a separate tests directory just for readability.

@TrangPham
Copy link
Contributor

kk lets merge this then we can move around the test files to a separate dir if we wanted

@NathanFarmer NathanFarmer merged commit 70ea4d5 into main Mar 6, 2024
2 of 3 checks passed
@NathanFarmer NathanFarmer deleted the f/FE-48/number-renderer-tests branch March 6, 2024 14:11
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrangPham TrangPham TrangPham approved these changes

@DrewHoo DrewHoo Awaiting requested review from DrewHoo

Assignees

@NathanFarmer NathanFarmer

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NathanFarmer @TrangPham @DrewHoo