Adding tests for boolean control #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrangPham
force-pushed
the
add-tests-for-boolean-control
branch
from
94065a2
to
b8454a5
Compare
DrewHoo
reviewed
Mar 11, 2024
src/antd/Checkbox.tsx
Outdated
| @@ -15,7 +15,7 @@ export function Checkbox({ data, className, id, enabled, uischema, schema, path, | |||
| return ( | |||
| <AntDCheckbox | |||
| checked={checked} | |||
| onChange={(e: CheckboxChangeEvent) => handleChange(path, e.target.checked)} | |||
| onChange={(e: CheckboxChangeEvent) => {handleChange(path, e.target.checked)}} | |||
There was a problem hiding this comment.
No I had added a console log here before. I'll update
TrangPham
commented
Mar 11, 2024
src/controls/BooleanControl.test.tsx
Outdated
Comment on lines
37
to
49
| const checkbox = await screen.findByLabelText("Name"); | ||
| expect(checkbox).not.toBeChecked(); | ||
| expect(updateData).not.toHaveBeenCalled(); | ||
|
|
||
| await userEvent.click(checkbox); | ||
| expect(checkbox).toBeChecked(); | ||
| // FYI the calls to updateData lag behind the actual checkbox state. Not sure why. | ||
| // It could be the difference between json-forms handleChange(path, value) and the onChange event. | ||
| expect(updateData).toHaveBeenLastCalledWith({ data: {name: false }, errors: []}); | ||
|
|
||
| await userEvent.click(checkbox); | ||
| expect(checkbox).not.toBeChecked(); | ||
| expect(updateData).toHaveBeenLastCalledWith({ data: {name: true }, errors: []}); |
There was a problem hiding this comment.
@DrewHoo i'm seeing this unexpected behavior within my test. Do you know where this could be coming from? I suspect it has something to do with how json form uses handleChange(path, value)
src/antd/Checkbox.tsx
Outdated
| @@ -15,7 +15,7 @@ export function Checkbox({ data, className, id, enabled, uischema, schema, path, | |||
| return ( | |||
| <AntDCheckbox | |||
| checked={checked} | |||
| onChange={(e: CheckboxChangeEvent) => handleChange(path, e.target.checked)} | |||
| onChange={(e: CheckboxChangeEvent) => {handleChange(path, e.target.checked)}} | |||
There was a problem hiding this comment.
No I had added a console log here before. I'll update
TrangPham
force-pushed
the
add-tests-for-boolean-control
branch
from
5abaac6
to
f0015c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.