Adding ObjectControl #26
Conversation
| () => | ||
| isEmpty(path) | ||
| ? Generate.uiSchema(schema, "VerticalLayout") | ||
| : { ...Generate.uiSchema(schema, "Group"), label }, |
There was a problem hiding this comment.
I migrated the GroupRenderer since I think this needs that
| if (!visible) { | ||
| return null | ||
| } |
There was a problem hiding this comment.
nit: I've been moving these to the top so you don't call findUISchema.
There was a problem hiding this comment.
Since findUISchema is within a react hook it cannot be conditional.
src/layouts/GroupRenderer.tsx
Outdated
| elements: UISchema[] | ||
| } | ||
|
|
||
| export function GroupComponent({ visible, enabled, uischema, ...props }: LayoutRendererProps) { |
There was a problem hiding this comment.
Trying to wrap my head around these layouts. Why is this called GroupComponent but the file is called GroupRenderer? I don't love the names "component' or "renderer" TBH. What would you think if we called them both GroupLayout and aliased the jsonforms interface?
There was a problem hiding this comment.
That sounds good. Not sure why it was named that before, but I just ported the naming over.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.