fix: update readme, update codecov to exclude storybook #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilo59
reviewed
Apr 16, 2024
vite.config.ts
Outdated
Comment on lines
13
to
16
| reporter: process.env.GITHUB_ACTIONS | ||
| ? ["github-actions", "cobertura"] | ||
| : ["text", "html", "clover", "json"], | ||
| reportsDirectory: "html/coverage", |
There was a problem hiding this comment.
Why do we need HTML reports at all if we are using codecovs app?
There was a problem hiding this comment.
How else would you view coverage locally without pushing changes first?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
===========================================
+ Coverage 63.61% 76.52% +12.91%
===========================================
Files 50 36 -14
Lines 492 409 -83
Branches 69 69
===========================================
Hits 313 313
+ Misses 159 76 -83
Partials 20 20 ☔ View full report in Codecov by Sentry. |
Kilo59
approved these changes
Apr 16, 2024
|
🎉 This PR is included in version 1.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.