fix(AnyOfControl): fix missing default combinator value bug #75
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 76.52% 76.78% +0.25%
==========================================
Files 36 36
Lines 409 435 +26
Branches 69 75 +6
==========================================
+ Hits 313 334 +21
- Misses 76 77 +1
- Partials 20 24 +4 ☔ View full report in Codecov by Sentry. |
DrewHoo
changed the title
| const [renderCount, setRenderCount] = useState(1) | ||
|
|
||
| useEffect(() => { | ||
| // this is a janky workaround for two problems |
There was a problem hiding this comment.
is the plan to work on the fix in @jsonforms/react next?
There was a problem hiding this comment.
No, I'm going to file a bug though. I'm not interested in fixing it upstream because ideally we have a different approach altogether for default creation.
There was a problem hiding this comment.
What we're doing in the closed-source renderer is worse:
- we're giving the FormItem a name for a field that doesn't correspond to a property we want in the form
- we're setting a value for that field in a useEffect so form validation doesn't complain (TBC I made this change back in December when the bug was blocking release of splitters)
| handleChange(path, newData) | ||
| } | ||
| } | ||
| if (renderCount === 1) { |
There was a problem hiding this comment.
does this count work properly?
There was a problem hiding this comment.
yep! this code makes the test pass
|
🎉 This PR is included in version 1.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Yes, I built the package locally and installed it to ensure it behaves as expected. Also my PR in mercury-web introduces a test that fails without the change included in this version. |
This PR fixes a couple problems: