fix: placeholders & password autocomplete

[elenajdanova]

[DrewHoo]

Setting autoComplete to "new-password" will cause browsers to treat the field as a new password and offer to generate one, for instance. That may be a use case for some folks using this library, but I don't think it's safe to assume it's the primary use case. If you want it to have specific configurable behavior, I'd suggest modifying TextControlOptions in src/ui-schema.ts to have an inputProps property typed similarly to TextControlInputProps in this file, so that users can configured this behavior via a UISchema.

[elenajdanova]

it was just a workaround to prevent auto-filling the input cause as it's mentioned in the article I posted in the comment

Even without a master password, in-browser password management is generally seen as a net gain for security. Since users do not have to remember passwords that the browser stores for them, they are able to choose stronger passwords than they would otherwise.
For this reason, many modern browsers do NOT support autocomplete="off" for login field

But they do support new-password in the right way.

I def can pass it as an input prop

[elenajdanova]

I realized we already use autocomplete so it would be strange to override it somewhere else in the code

[DrewHoo]

I think we should avoid accreting properties on TextControlOptions that are really just antd InputProps--did you try adding a inputProps property to TextControlOptions that's typed as antd's InputProps?

[elenajdanova]

yup, @DrewHoo can you take a look?

[codecov]

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.60%. Comparing base (768d8c4) to head (0557451).
Report is 2 commits behind head on main.

Files	Patch %	Lines
src/controls/TextControl.tsx	44.44%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   76.78%   76.60%   -0.18%     
==========================================
  Files          36       36              
  Lines         435      436       +1     
  Branches       75       75              
==========================================
  Hits          334      334              
- Misses         77       78       +1     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🎉 This PR is included in version 1.15.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀