Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add formItemProps to UI schemas #80

Merged
merged 27 commits into from
May 20, 2024

Conversation

NathanFarmer
Copy link
Contributor

@NathanFarmer NathanFarmer commented May 15, 2024

Enables passing a tooltip (as well as any other prop) through to AntD Form.Item via UI schemas.

@NathanFarmer NathanFarmer self-assigned this May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 75.59%. Comparing base (f8e084a) to head (a6c1f76).

Current head a6c1f76 differs from pull request most recent head 66e6d5a

Please upload reports for the commit 66e6d5a to get more accurate results.

Files Patch % Lines
src/controls/BooleanControl.tsx 33.33% 0 Missing and 2 partials ⚠️
src/controls/TextControl.tsx 50.00% 0 Missing and 2 partials ⚠️
src/controls/NumericControl.tsx 50.00% 0 Missing and 1 partial ⚠️
src/controls/NumericSliderControl.tsx 50.00% 0 Missing and 1 partial ⚠️
src/controls/ObjectArrayControl.tsx 50.00% 0 Missing and 1 partial ⚠️
src/controls/PrimitiveArrayControl.tsx 66.66% 0 Missing and 1 partial ⚠️
src/controls/combinators/AnyOfControl.tsx 50.00% 0 Missing and 1 partial ⚠️
src/controls/combinators/OneOfControl.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   76.60%   75.59%   -1.01%     
==========================================
  Files          36       36              
  Lines         436      459      +23     
  Branches       75       85      +10     
==========================================
+ Hits          334      347      +13     
  Misses         78       78              
- Partials       24       34      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NathanFarmer NathanFarmer marked this pull request as ready for review May 15, 2024 20:31
Copy link

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! I did not functionally validate this. Let me know if that would be helpful. Probably worth getting a second a opinion since I am not familiar with the code base.

Copy link
Contributor

@DrewHoo DrewHoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing

src/controls/utils.tsx Outdated Show resolved Hide resolved
@NathanFarmer NathanFarmer changed the title feat: Add tooltip option to all UI schemas feat: Add formItemProps to UI schemas May 20, 2024
@NathanFarmer NathanFarmer requested a review from DrewHoo May 20, 2024 15:16
src/controls/BooleanControl.tsx Outdated Show resolved Hide resolved
@NathanFarmer NathanFarmer requested a review from DrewHoo May 20, 2024 16:12
src/controls/ObjectArrayControl.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@DrewHoo DrewHoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--I left a comment on defining ControlProps more clearly in BooelanControl.tsx and similar components, but not gonna block on that. Nice work!

@NathanFarmer NathanFarmer merged commit 37fd72a into main May 20, 2024
2 of 3 checks passed
@NathanFarmer NathanFarmer deleted the f/ph-1294/tooltip-in-all-ui-schemas branch May 20, 2024 17:36
Copy link

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants