fix: Deprecate options.tooltip #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elenajdanova
commented
Jun 18, 2024
•
elenajdanova
commented
- Deprecate options.tooltip
- Fixed how we consume tooltip props as we were doing it in 2 different places
- Added additional stories & tests
elenajdanova
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 75.22% 75.49% +0.27%
==========================================
Files 36 36
Lines 452 453 +1
Branches 85 86 +1
==========================================
+ Hits 340 342 +2
Misses 78 78
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. |
DrewHoo
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Interweave doesn't look like it is actively maintained & daily downloads are on the low side. Would something like https://www.npmjs.com/package/react-markdown work?
DrewHoo
reviewed
Jun 25, 2024
DrewHoo
requested changes
Jun 25, 2024
DrewHoo
reviewed
Jun 25, 2024
elenajdanova
changed the title
elenajdanova
changed the title
elenajdanova
force-pushed
the
b/lak-1028/upgrade-tooltips
branch
from
6fae156
to
a31db29
Compare
DrewHoo
requested changes
Jun 25, 2024
|
🎉 This PR is included in version 1.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.