Support static bitmasks as LED patterns.

greatscottgadgets · Sep 7, 2023 · 300f083 · 300f083
1 parent 799b3a2
commit 300f083
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 20 deletions.
diff --git a/firmware/src/boards/luna_d11/led.c b/firmware/src/boards/luna_d11/led.c
@@ -25,16 +25,6 @@
 static blink_pattern_t blink_pattern = BLINK_IDLE;
 
 
-/**
- * Sets the active LED blink pattern.
- */
-void led_set_blink_pattern(blink_pattern_t pattern)
-{
-    blink_pattern = pattern;
-    leds_off();
-}
-
-
 /**
  * Sets up each of the LEDs for use.
  */
@@ -125,6 +115,21 @@ static void display_led_number(uint8_t number)
 }
 
 
+/**
+ * Sets the active LED blink pattern.
+ */
+void led_set_blink_pattern(blink_pattern_t pattern)
+{
+    blink_pattern = pattern;
+    leds_off();
+    if (blink_pattern < 32) {
+      for (int i = 0; i < 5; i++) {
+        display_led_number(i);
+      }
+    }
+}
+
+
 /**
  * Task that handles blinking the heartbeat LED.
  */
@@ -134,6 +139,10 @@ void heartbeat_task(void)
   static uint8_t active_led = 0;
   static bool count_up = true;
 
+  if (blink_pattern < 32) {
+    return;
+  }
+
   // Blink every interval ms
   if ( board_millis() - start_ms < blink_pattern) return; // not enough time
   start_ms += blink_pattern;

diff --git a/firmware/src/boards/luna_d21/led.c b/firmware/src/boards/luna_d21/led.c
@@ -25,16 +25,6 @@
 static blink_pattern_t blink_pattern = BLINK_IDLE;
 
 
-/**
- * Sets the active LED blink pattern.
- */
-void led_set_blink_pattern(blink_pattern_t pattern)
-{
-	blink_pattern = pattern;
-	leds_off();
-}
-
-
 /**
  * Sets up each of the LEDs for use.
  */
@@ -112,6 +102,21 @@ static void display_led_number(uint8_t number)
 }
 
 
+/**
+ * Sets the active LED blink pattern.
+ */
+void led_set_blink_pattern(blink_pattern_t pattern)
+{
+    blink_pattern = pattern;
+    leds_off();
+    if (blink_pattern < 32) {
+      for (int i = 0; i < 5; i++) {
+        display_led_number(i);
+      }
+    }
+}
+
+
 /**
  * Task that handles blinking the heartbeat LED.
  */
@@ -121,6 +126,10 @@ void heartbeat_task(void)
   static uint8_t active_led = 0;
   static bool count_up = true;
 
+  if (blink_pattern < 32) {
+    return;
+  }
+
   // Blink every interval ms
   if ( board_millis() - start_ms < blink_pattern) return; // not enough time
   start_ms += blink_pattern;