Add basic debug logging #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicgs
reviewed
Aug 19, 2018
| // Possible log levels. | ||
| enum debug_log_level { | ||
| LOGLEVEL_EMERGENCY, | ||
| LOGLEVEL_ALERT, |
There was a problem hiding this comment.
Should there be accompanying pr_alert() and pr_critical()functions?
firmware/common/debug.h
Outdated
| enum debug_log_level { | ||
| LOGLEVEL_EMERGENCY, | ||
| LOGLEVEL_ALERT, | ||
| LOGLEVEL_CRITITCAL, |
There was a problem hiding this comment.
Should it be LOGLEVEL_CRITICAL? (spelling)
|
My review is two minor nitpicks. The rest of it looks great and I'm happy to merge it if you have counter arguments to my nitpicks. |
|
Review comments looked good; addressed them. Thanks; here's an updated PR. :) |
|
Apparently you can't merge and then approve, but rest assured, I reviewed and approved of the last commit too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a linux-like debug logging mode:
printklogs to a ringbuffer, which can be queried usinggreatfet dmesg.