Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateware: fix pin assignments and remove deprecated Case() #239

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mndza
Copy link
Contributor

@mndza mndza commented Mar 11, 2024

No description provided.

Copy link
Member

@miek miek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoinevg
Copy link
Member

This is failing the CI tests: https://github.com/greatscottgadgets/luna/actions/runs/8236675456/job/22523664217#step:5:32

This is building for me on amaranth==0.4.1 which should be equivalent to luna's amaranth~=0.4.0 but I'm probably the last person to ask about pip package resolution.

We're in a weird place, we need a stable pin for cynthion release but there's a lot of things in luna we need for urti and it would be nice to not have to rewrite them when amaranth>=0.5 comes out. 😛

@miek
Copy link
Member

miek commented Mar 11, 2024

This is building for me on amaranth==0.4.1 which should be equivalent to luna's amaranth~=0.4.0 but I'm probably the last person to ask about pip package resolution.

Is that just building a design, or running the tests? That test fails locally for me with amaranth 0.4.1.

@antoinevg
Copy link
Member

Argh okay, I only ran builds here.

@antoinevg antoinevg requested review from antoinevg and removed request for antoinevg March 12, 2024 05:10
@mndza
Copy link
Contributor Author

mndza commented Mar 12, 2024

Updated the tests.

@miek
Copy link
Member

miek commented Mar 12, 2024

Thanks!

@miek miek merged commit bec6179 into greatscottgadgets:main Mar 12, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants