edited README #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,12 +27,13 @@ Observed has has a very small code-base (only a few hundred lines) which makes r | |||
| Observed's extensible design through plugins is inspired by other Ruby projects such as Fluentd. People familiar with other Ruby products should feel right at home with Observed. As of now it is a highly ambitious and experimental framework with big potential for growth and improvements. | |||
|
|
|||
| Observed is (and its plugins should be) stateless. | |||
| This means that it should work in the same manner whether it is run as a daemon or a _oneshot_ application like | |||
| a regular cron job, as states should be stored outside of the application instance with regards to Observed. | |||
| This means that it should work in the same manner whether it is run as a daemon or a regular cron job, as states should be stored outside of the Observed application instance. | |||
There was a problem hiding this comment.
ググってみたところoneshotはそんなに標準的な言い方に思えなかったので、外したほうがいいかなと思いました
There was a problem hiding this comment.
oneshot applicationなどと書かなくても分かりやすいですね！
| @@ -89,11 +91,13 @@ include Clockwork | |||
|
|
|||
| the_dir = Pathname.new(File.dirname(__FILE__)) | |||
|
|
|||
| # The following two lines are specific to Observed's Clockwork support. | |||
There was a problem hiding this comment.
こういう風に個別にコメント入れたほうがわかりやすいかと思います
|
@brandonheato I totally agree with the suggestions :) Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.