Accept Number as valid type for filter array #16
Comments
|
@lrholmes - definitely still maintained, I'd be happy to merge a PR for this! |
bfirsh
added a commit
to bfirsh/react-firestore
that referenced
this issue
May 30, 2018
For example: `filter={["thing", "==", db.doc("things/" + thing)]}`
Fixes green-arrow#16
bfirsh
added a commit
to bfirsh/react-firestore
that referenced
this issue
Jun 1, 2018
For example: `filter={["thing", "==", db.doc("things/" + thing)]}`
fix green-arrow#16
bfirsh
added a commit
to bfirsh/react-firestore
that referenced
this issue
Jun 7, 2018
For example: `filter={["thing", "==", db.doc("things/" + thing)]}`
fix green-arrow#16
bfirsh
added a commit
to bfirsh/react-firestore
that referenced
this issue
Jun 7, 2018
For example: `filter={["thing", "==", db.doc("things/" + thing)]}`
fix green-arrow#16
bfirsh
added a commit
to bfirsh/react-firestore
that referenced
this issue
Jun 7, 2018
For example: `filter={["thing", "==", db.doc("things/" + thing)]}`
fix green-arrow#16
green-arrow
pushed a commit
that referenced
this issue
Jun 7, 2018
* docs: Format README.md
The precommit hook did this automatically.
* fix: Allow numbers and objects in filters
For example: `filter={["thing", "==", db.doc("things/" + thing)]}`
Closes #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently using a number to filter a collection query causes a PropType error, when it is actually valid. In fact, changing the number to a string to silence the warning breaks the filter.
I'm happy to contribute the fix for this, if you can confirm that this project is still being maintained? Hope so!
The text was updated successfully, but these errors were encountered: