Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 208 better build #213

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Feature/issue 208 better build #213

wants to merge 3 commits into from

Conversation

jycr
Copy link
Contributor

@jycr jycr commented Jul 21, 2023

fix #208

@dedece35 dedece35 self-requested a review July 26, 2023 07:50
@dedece35 dedece35 added 🚀 enhancement New feature or request 🏗️ refactoring refactoring for best practices labels Jul 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 8, 2023
@dedece35
Copy link
Member

Hi @jycr,
sorry but we have to discuss about this feature because I don't know it and I have some questions.

@jycr
Use Maven CI Friendly Versions
9077ab9 
More information:
* [Maven CI Friendly Versions - Apache Maven Project](https://maven.apache.org/maven-ci-friendly.html)
* [Maven Git Versioning Extension](https://github.com/qoomon/maven-git-versioning-extension)
@jycr
Ensure build reproducibility
214ff70 
More information:
* [Configuring for Reproducible Builds - Apache Maven Project](https://maven.apache.org/guides/mini/guide-reproducible-builds.html)
@jycr jycr force-pushed the feature/ISSUE-208--better-build branch from f575288 to 214ff70 Compare October 22, 2023 15:43
@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jycr
Copy link
Contributor Author

jycr commented Oct 22, 2023 •
edited

Hi @jycr, sorry but we have to discuss about this feature because I don't know it and I have some questions.

@dedece35: No problem to discuss it together.
But we can wait to split java-plugin into its own repo before finishing this PR?

@dedece35
Copy link
Member

dedece35 commented Oct 22, 2023 •
edited

Hi @jycr, sorry but we have to discuss about this feature because I don't know it and I have some questions.

@dedece35: No problem to discuss it together. But we can wait to split java-plugin into its own repo before finishing this PR?

@jycr ... yes I think we should wait automatic release PR (#209) before merging this one

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 22, 2023
@dedece35 dedece35 marked this pull request as draft December 1, 2023 21:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the stale label Dec 2, 2023
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 Awaiting requested review from dedece35

At least 1 approving review is required to merge this pull request.

Assignees

@jycr jycr

Labels
🏗️ refactoring refactoring for best practices 🔥 in progress 🔥 🚀 enhancement New feature or request stale 👀 👀 waiting commiter 👀 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use "Maven Friendly Version"
2 participants
@jycr @dedece35