Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rules added in JS module v1.4.0 #226

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Support rules added in JS module v1.4.0 #226

merged 2 commits into from
Oct 27, 2023

Conversation

utarwyn
Copy link
Member

@utarwyn utarwyn commented Sep 18, 2023 •
edited
Loading

This PR adds the documentation for the following JavaScript rules:

  • Limit DB query result (EC24)
  • No empty image src attribute (EC25)
  • Prefer shorthand CSS notations (EC26)
  • Avoid CSS animations (EC29)
  • Provide CSS print (EC30)

Maybe we should merge #209 first? Should I update the CHANGELOG file?

Further info in green-code-initiative/ecoCode-javascript#23

@utarwyn utarwyn added the 🚀 enhancement New feature or request label Sep 18, 2023
@utarwyn utarwyn self-assigned this Sep 18, 2023
@dedece35
Copy link
Member

dedece35 commented Sep 22, 2023 •
edited
Loading

Hi @utarwyn, @jycr

I'm ok that the PR #209 should be merged before. Indeed, there is modifications inside for javascript part.
Then, this current PR will have some conflicts to resolve.

Maybe, update this PR to be draft, no ?

@utarwyn utarwyn marked this pull request as draft September 22, 2023 08:53
@dedece35 dedece35 mentioned this pull request Sep 22, 2023
Merged
@utarwyn utarwyn mentioned this pull request Sep 27, 2023
Merged
dedece35
dedece35 previously approved these changes Oct 6, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@utarwyn utarwyn marked this pull request as ready for review October 27, 2023 16:56
@utarwyn utarwyn requested review from dedece35 and jycr and removed request for jycr October 27, 2023 16:56
dedece35
dedece35 reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utarwyn I'm ok
for information, #209 has just been merged by @jycr. We can now merge this current PR.
But, is RULES.md updated with these modifications ?

@utarwyn
Copy link
Member Author

utarwyn commented Oct 27, 2023

@dedece35 thank you!

Yes, the RULES.md file will be updated in the next PR of the dedicated repository:
https://github.com/green-code-initiative/ecoCode-javascript/pull/26/files#diff-a8ebbd66b8e411f87705f68905b9537f36a55e5d2154cd65bb0ab0e60acda150

@utarwyn utarwyn merged commit d21cee0 into main Oct 27, 2023
3 checks passed
@utarwyn utarwyn deleted the add-javascript-rules branch October 27, 2023 17:50
@utarwyn utarwyn mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 dedece35 approved these changes

@jycr jycr Awaiting requested review from jycr

Assignees

@utarwyn utarwyn

Labels
🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@utarwyn @dedece35