Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 Refactor #24

Closed
1 of 8 tasks
chrisui opened this issue Jan 13, 2016 · 4 comments
Closed
1 of 8 tasks

v1 Refactor #24

chrisui opened this issue Jan 13, 2016 · 4 comments

Comments

@chrisui
Copy link
Contributor

chrisui commented Jan 13, 2016

Issue to track/discuss upcoming features/changes.

@chrisui
Copy link
Contributor Author

chrisui commented Mar 29, 2016

Potentially provide first class support for initial focus state?

See: #25

@MLoughry
Copy link

MLoughry commented Nov 7, 2016

@chrisui In my project, I'm already working on an HOC API wrapper around this project that I may be able to port over to this project. However, without PR #40 (or at least allowing the wrapping div to be styled), it has some issues.

The working prototype I have provides

  • @registerKeyMap class decorator that takes in a keyMap argument, and wraps the class's render method in a component
  • @keydownHandler method decorator that takes in a string command argument. It then wraps the class's render method with a method with a map of all decorated methods in the class.

However, I want to be sure this project is still open to development before spending effort porting my prototype to this project.

@chrisui
Copy link
Contributor Author

chrisui commented Feb 7, 2017

Have finally (!!?!?!) kicked off this work. First priority has been getting everything updated (a lot has changed in 2 years!) and ensuring we have a robust way of testing the hotkey events so we can have good coverage. Still working on that latter part but hopefully have something to show soon!

@greena13
Copy link
Owner

Closing to track the issues individually - milestones are now being used to group issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants