-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate handlers to single Mousetrap binding #2
Comments
Having a single |
Note with 98b65bc the propagation issue seen in the mentioned example is now fixed. A single delegation point should still be written though for best performance moving forwards. |
Closing to be tracked in #2 Might re-open if it drops from v1 scope. |
Reopening to track separately. |
Closing as soon to be no longer relevant, with the removal of Mousetrap in version 2.0.0 |
HotKeys
currently creates a Mousetrap instance for each component mounted. This could be optimized for the cases where you had many hotkey targets (imagine hundreds of node's you had a 'delete' hotkey for) by having a single instance where handlers were bound to.The text was updated successfully, but these errors were encountered: