Bugfix nonprintable keys #199
Conversation
| @@ -1,27 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
🐥 Remove separate file previously used to record keys without keypress events - this is now just the list of non-printable keys.
| @@ -0,0 +1,10 @@ | |||
| /** | |||
There was a problem hiding this comment.
🐥 New dictionary of non-printable keys, that takes its values from the same list that the React normalization algorithm uses.
| @@ -1,13 +0,0 @@ | |||
| import SpecialKeysDictionary from '../../const/SpecialKeysDictionary'; | |||
There was a problem hiding this comment.
🐥 Move the list of "special" keys, to be referred to as "non-printable"
| return isSpecialKey(keyName) || String.fromCharCode(keyName.charCodeAt(0)) === keyName; | ||
| return isNonPrintableKeyName(keyName) || | ||
| String.fromCharCode(keyName.charCodeAt(0)) === keyName || | ||
| Configuration.option('customKeyCodes')[keyName]; |
There was a problem hiding this comment.
✅🐛Fix this line - incorrect way of accepting custom keys (it's a map of key codes to key names and this lookup will always fail).
| @@ -28,50 +29,6 @@ const normalizeKey = { | |||
| MozPrintableKey: 'Unidentified', | |||
| }; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
🐥☂️Abstract React's list of non-printable keys into a separate file, so it can be re-used by react-hotkeys.
Context
react-hotkeysuses a whitelist of accepted keynames in order to fail loudly if a user of the library enters an invalid key name. This list is currently incomplete, resulting in #198.This pull request
Takes the lead from the way that
reactitself handles keys, and consolidates all of the follow features into a single list:react-hotkeysfor global hotkeys that occur outside the React application)keypressevent, or whether it should be simulated (all non-printable keys do not have akeypressevent)react-hotkeysmay have made a mistake in defining their key sequence