Fix cli options, deprecate pep8, fix 2of3 example #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove also 2of3 basic options group
This makes the advanced_2of3 options' help accessible from the cli.
In addition fix few style errors previously ignored.
Passing more options makes the example run in a reasonable time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some cli options (some helps were not accessible from cli, some flags were unused).
pep8 is deprecated, use pycodestyle instead.
2of3 example did not work (missing destination), in addition I added few options so it runs in a reasonable amount of time (although it does not recover any fund).