Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add ruff #564

Closed
jorgegomzar opened this issue Jun 9, 2023 · 5 comments
Closed

Request to add ruff #564

jorgegomzar opened this issue Jun 9, 2023 · 5 comments

Comments

@jorgegomzar
Copy link

jorgegomzar commented Jun 9, 2023

Hi! I've recently discovered your project and immediately added a bunch of autohooks plugins to my projects.

I wanted to add ruff pre-commit so I followed your documentation and created my own by creating a fork of your pylint plugin.

What is your usual workflow for this? Should I publish the plugin to PyPI or would you rather create a fork to keep everything under the same team?

Thanks for everything, love your work!

@bjoernricks
Copy link
Member

Hi,

as this is the second request for a ruff plugin (first was #511) and I also want to play with ruff in near future so I am in favor of creating an "official" ruff plugin in the greenbone space.

Would it be ok for you if I take your code as the base? Or should I create an initial repo and you are going to rebase your commits against that repo and create a PR?

@jorgegomzar
Copy link
Author

Whichever is easier for you guys!

@bjoernricks
Copy link
Member

Because I wont have that much time next week, it is easiest if you create a PR against https://github.com/greenbone/autohooks-plugin-ruff

@jorgegomzar
Copy link
Author

Got it! I've cleaned the code a bit + added git config to the docker dev env.
Here is the PR greenbone/autohooks-plugin-ruff#1

@bjoernricks
Copy link
Member

Created a release on pypi https://pypi.org/project/autohooks-plugin-ruff/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants