Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont rely on auto activation #52

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Dont rely on auto activation #52

merged 4 commits into from
Apr 7, 2020

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 7, 2020 •
edited
Loading

Checklist:

@bjoernricks
Auto activation isn't reliable
1927f97 
Don't depend on source distibutions and auto activation anymore. This
doesn't work reliable. Users shouls call autohooks activate now.
@bjoernricks
Remove deleted pipfiles from MANIFEST.in
61de5f2 
We switched to poetry and these files aren't available anymore.
@codecov
Copy link

codecov bot commented Apr 7, 2020 •
edited
Loading

Codecov Report

Merging #52 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   51.63%   51.63%           
=======================================
  Files          14       14           
  Lines         732      732           
=======================================
  Hits          378      378           
  Misses        354      354

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0e842...3caa682. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review April 7, 2020 07:22
@bjoernricks bjoernricks merged commit 43602d2 into greenbone:master Apr 7, 2020
@bjoernricks bjoernricks deleted the dont-rely-on-auto-activation branch April 7, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjoernricks @wiegandm