Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line-breaks and other improvements for the terminal output #66

Merged
merged 7 commits into from Aug 26, 2020

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Aug 25, 2020

If a line is larger than the terminals width, it will be broken correctly ... hopefully.
Changed the status from right to left, from text to symbol ...

Example:

ℹ autohooks => pre-commit
ℹ     Running autohooks.plugins.black
✓         Running black on autohooks/precommit/run.py
✓         Running black on autohooks/terminal.py
✓         Running black on tests/test_terminal.py
ℹ     Running autohooks.plugins.pylint
************* Module terminal
autohooks/terminal.py:70:12: E0602: Undefined variable 'part_line' (undefined-variable)
************* Module tests.test_terminal
tests/test_terminal.py:160:0: C0301: Line too long (184/80) (line-too-long)
tests/test_terminal.py:161:0: C0301: Line too long (176/80) (line-too-long)
✖         Linting error(s) found in autohooks/precommit/run.py, autohooks/terminal.py, tests/test_terminal.py.

Checklist:

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #66 into master will increase coverage by 2.11%.
The diff coverage is 91.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   46.31%   48.43%   +2.11%     
==========================================
  Files          13       13              
  Lines         557      576      +19     
==========================================
+ Hits          258      279      +21     
+ Misses        299      297       -2     
Impacted Files Coverage Δ
autohooks/precommit/run.py 0.00% <0.00%> (ø)
autohooks/terminal.py 96.92% <97.72%> (+5.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebefe93...29e23a3. Read the comment docs.

Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bjoernricks bjoernricks merged commit 4c8b0f3 into greenbone:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants