Fix segfault due to NULL save_config_nvt_omp response #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the response string given to send_response is NULL, log a warning and send an empty response with HTTP code 500.
Now a generic success message is returned if no errors occur to ensure there is a valid response. Previously the returned message could be NULL if it was not set by check_modify_config because there are no preferences given or the last preference was skipped (e.g. if it's a password where the "Replace existing ..." box was not checked).
bjoernricks
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a segfault that could occur if the last preference on an NVT preferences edit dialog is skipped, e.g. when it's a password that's not overwritten, or possibly if no preferences are sent at all.
The first commit is about preventing the segfault in case a NULL response is passed to send_response, while the second one prevents save_config_nvt_omp from returning a NULL response under the conditions above.