Model boolean parsing #1406
Merged
Model boolean parsing #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol is not very specific about boolean values. We have considered '1' for 'true' and '0' for 'false' at the parseYesNo function but this may not sufficient. Therefore add a new parser function to 1. Use real boolean values (true/false) in the js code 2. Consider more values as true like the protocol does
Test also parsing of orphan, active and trash values.
Add tests for isInTrash, isWriteable and isOrphan.
These methods are now tested via the testModel test creator function automatically.
Parse in_use with parseBoolean and as inUse property.
* isInUse should be passed as prop to the dialogs and not checked within the dialog * Dialogs should not require a model in future and expect all arguments as props * isInUse should be the variable name instead of in_use To implement all these points further commits are required. This commit only touches code paths which are easy to change without the risk to break existing code.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1406 +/- ##
===========================================
+ Coverage 36.51% 36.68% +0.16%
===========================================
Files 960 960
Lines 21678 21739 +61
Branches 6033 6039 +6
===========================================
+ Hits 7915 7974 +59
- Misses 12432 12434 +2
Partials 1331 1331
Continue to review full report at Codecov.
|
sarahd93
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: