Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using filename templates #1512

Merged
merged 22 commits into from Jul 24, 2019
Merged

Fix using filename templates #1512

merged 22 commits into from Jul 24, 2019

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp self-assigned this Jul 24, 2019
@swaterkamp swaterkamp marked this pull request as ready for review July 24, 2019 12:36
@swaterkamp swaterkamp requested a review from a team July 24, 2019 12:36
bjoernricks
bjoernricks requested changes Jul 24, 2019
View reviewed changes
Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid crashing if usersettings couldn't be loaded

gsa/src/web/entities/container.js Outdated Show resolved Hide resolved
gsa/src/web/entities/container.js Outdated Show resolved Hide resolved
gsa/src/web/entity/component.js Outdated Show resolved Hide resolved
gsa/src/web/entity/component.js Outdated Show resolved Hide resolved
gsa/src/web/pages/agents/component.js Outdated Show resolved Hide resolved
gsa/src/web/pages/results/detailspage.js Outdated Show resolved Hide resolved
gsa/src/web/pages/results/detailspage.js Outdated Show resolved Hide resolved
gsa/src/web/pages/scanners/component.js Outdated Show resolved Hide resolved
gsa/src/web/pages/scanners/component.js Outdated Show resolved Hide resolved
gsa/src/web/pages/scanners/component.js Outdated Show resolved Hide resolved
swaterkamp and others added 16 commits July 24, 2019 15:20
@swaterkamp @bjoernricks
Update gsa/src/web/entities/container.js
e8e0c1f 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/entities/container.js
950e426 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/entity/component.js
9286948 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/entity/component.js
1d16d81 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/agents/component.js
9002fe5 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/results/detailspage.js
aefa52e 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/results/detailspage.js
3399b21 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/scanners/component.js
6edd6c2 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/scanners/component.js
e046171 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/scanners/component.js
c35964f 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/agents/component.js
5ac40f7 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/credentials/component.js
19d53c1 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/credentials/component.js
3664e26 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/reports/detailspage.js
4c86b38 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp @bjoernricks
Update gsa/src/web/pages/reports/detailspage.js
7b058e7 
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@swaterkamp
Merge branch 'gsa-8.0' into FilenameTemplates
d63b440
@bjoernricks bjoernricks merged commit 44c0452 into greenbone:gsa-8.0 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees

@swaterkamp swaterkamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swaterkamp @bjoernricks