Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified edit schedule dialog to avoid start date in the past #1519

Merged
merged 3 commits into from Jul 25, 2019

Conversation

saberlynx
Copy link
Contributor

  • Added a "now" button to help users jump to current date
  • Added year dropdown in case users deal with timeframes far from now, to avoid excessive clicking.
  • Changed some titles to hopefully make explicit to the user values they're changing

Checklist:

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #1519 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
- Coverage   37.15%   37.14%   -0.01%     
==========================================
  Files        1001     1001              
  Lines       22330    22335       +5     
  Branches     6143     6143              
==========================================
  Hits         8297     8297              
- Misses      12719    12724       +5     
  Partials     1314     1314
Impacted Files Coverage Δ
gsa/src/web/pages/schedules/dialog.js 10.23% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b101d5...498855c. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review July 25, 2019 13:39
@bjoernricks bjoernricks merged commit 320187b into greenbone:master Jul 25, 2019
@saberlynx saberlynx deleted the scheduleDialog branch August 6, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants