Fix handling error response during gmp authentication in gsad #1700

bjoernricks · 2019-10-17T13:15:30Z

Handle errors while trying to authenticate against gvmd more carefully.

Checklist:

[n/a] Tests
CHANGELOG Entry

When a user has a session and it is not possible to connect to manager return a 4xx or 5xx http response. Update manager_connection function to return more specific error codes.

Change the meaning of the return values to be consistent with gmp_authenticate.

If an unknown error occurs during authentication don't request re-authentication in GSA. This allows to show an error instead of invalidating the user session.

Handle all error cases from manager_connect in handle_system_report function. This allows to return a more specific error message.

Return all error codes from authenticate_gmp and create specific http error responses.

timopollmeier

I found a typo in handle_system_report but besides that it looks okay to me.

gsad/src/gsad_http_handler.c

Co-Authored-By: Timo Pollmeier <timo.pollmeier@greenbone.net>

bjoernricks added 2 commits October 17, 2019 13:07

Fix sending error responses

e00812b

When a user has a session and it is not possible to connect to manager return a 4xx or 5xx http response. Update manager_connection function to return more specific error codes.

Improve handling error code for user authentication

e9a70f9

Change the meaning of the return values to be consistent with gmp_authenticate.

bjoernricks requested a review from timopollmeier as a code owner October 17, 2019 13:15

Add changelog entry

3f2c4e6

bjoernricks requested a review from swaterkamp as a code owner October 17, 2019 13:17

bjoernricks added 3 commits October 17, 2019 16:33

Don't request re-authentication on unknown errors

82fd519

If an unknown error occurs during authentication don't request re-authentication in GSA. This allows to show an error instead of invalidating the user session.

Update handle_system_report to handle more error cases

4463348

Handle all error cases from manager_connect in handle_system_report function. This allows to return a more specific error message.

Return timeout error code from authenticate_gmp

e70df9f

Return all error codes from authenticate_gmp and create specific http error responses.

timopollmeier reviewed Oct 17, 2019

View reviewed changes

gsad/src/gsad_http_handler.c Outdated Show resolved Hide resolved

Fix typo

cc6c468

Co-Authored-By: Timo Pollmeier <timo.pollmeier@greenbone.net>

bjoernricks requested a review from timopollmeier October 18, 2019 06:15

timopollmeier approved these changes Oct 18, 2019

View reviewed changes

bjoernricks merged commit 58abfa3 into greenbone:gsa-9.0 Oct 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix handling error response during gmp authentication in gsad #1700

Fix handling error response during gmp authentication in gsad #1700

bjoernricks commented Oct 17, 2019 •

edited

timopollmeier left a comment

Fix handling error response during gmp authentication in gsad #1700

Fix handling error response during gmp authentication in gsad #1700

Conversation

bjoernricks commented Oct 17, 2019 • edited

timopollmeier left a comment

Choose a reason for hiding this comment

bjoernricks commented Oct 17, 2019 •

edited