Only show schedule options in advanced and modify task wizard if user has correct permissions #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahd93
changed the title
bjoernricks
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The advanced task wizard offers the user to create a schedule even if the user does not have the permissions to do it (for example on a GSM without schedules). The modify wizard has the same problem.
Why:
Only allow the use of schedules in the wizards if the user can access and create them like we already do for alerts. Also don't show the modify wizard when both alerts and schedules are not available since it is useless in that case.
How:
Added tests for both wizards and tested it manually with a user that does not have the correct permissions.
Checklist: