Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to delete process without having had edges #2507

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Allow to delete process without having had edges #2507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
383f472
Allow to delete processes without having had edges
swaterkamp Oct 13, 2020
0b3babd
Update Changelog
swaterkamp Oct 13, 2020
55e214b
Merge branch 'gsa-20.08' into delProcWithNoEdge
swaterkamp Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Use <predefined> to disable feed object editing and filter creation on feed status page [#2398](https://github.com/greenbone/gsa/pull/2398)

### Fixed
- Allow to delete processes without having had edges in BPM [#2507](https://github.com/greenbone/gsa/pull/2507)
- Fixed TLS certificate download for users with permissions [#2496](https://github.com/greenbone/gsa/pull/2496)
- Fixed form validation error tooltips [#2478](https://github.com/greenbone/gsa/pull/2478)
- Only show schedule options in advanced and modify task wizard if user has correct permissions [#2472](https://github.com/greenbone/gsa/pull/2472)
Expand Down
2 changes: 1 addition & 1 deletion gsa/src/web/components/processmap/processmap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ class ProcessMap extends React.Component {
handleDeleteElement() {
if (isDefined(this.selectedElement)) {
const {id} = this.selectedElement;
const {processes, edges} = this.state;
const {processes, edges = {}} = this.state;
if (isDefined(id)) {
if (this.selectedElement && this.selectedElement.type === 'edge') {
delete edges[id];
Expand Down