Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure superadmins can edit themselves #2633

Merged
merged 4 commits into from
Dec 16, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Dec 15, 2020

What:

Skip elements in MODIFY_USER that would prevent a superadmin from saving themself.

Why:

Superadmins should be able to edit themselves.

How:

Login as superadmin s. Menu > Users. Click edit icon for user s. Edit comment. Click Save.

Checklist:

@mattmundell mattmundell marked this pull request as ready for review December 15, 2020 18:16
@mattmundell mattmundell requested a review from a team December 15, 2020 18:16
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #2633 (08f8379) into gsa-20.08 (2f34292) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-20.08    #2633   +/-   ##
==========================================
  Coverage      53.06%   53.07%           
==========================================
  Files           1072     1072           
  Lines          25900    25904    +4     
  Branches        7372     7372           
==========================================
+ Hits           13744    13748    +4     
  Misses         11034    11034           
  Partials        1122     1122           
Impacted Files Coverage Δ
gsa/src/web/pages/users/detailspage.js 33.33% <ø> (ø)
gsa/src/web/pages/users/row.js 26.66% <ø> (ø)
gsa/src/gmp/models/user.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d835530...08f8379. Read the comment docs.

@swaterkamp swaterkamp merged commit f3a8c7c into greenbone:gsa-20.08 Dec 16, 2020
@mattmundell mattmundell deleted the edit-superadmin branch December 21, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants